Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-02-01 Thread Xueming Shen
On 01/22/2013 02:58 PM, Alan Bateman wrote: On 22/01/2013 22:19, David Holmes wrote: All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or desirable) to build into jdk/lib and then copy over. Sherman can confirm, but I believe the

Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-01-23 Thread Erik Joelsson
On 2013-01-23 01:14, David Holmes wrote: On 23/01/2013 9:08 AM, Xueming Shen wrote: On 01/22/2013 02:58 PM, Alan Bateman wrote: On 22/01/2013 22:19, David Holmes wrote: All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or desirable

Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-01-22 Thread David Holmes
On 23/01/2013 9:08 AM, Xueming Shen wrote: On 01/22/2013 02:58 PM, Alan Bateman wrote: On 22/01/2013 22:19, David Holmes wrote: All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or desirable) to build into jdk/lib and then copy over

Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-01-22 Thread Alan Bateman
On 22/01/2013 22:19, David Holmes wrote: All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or desirable) to build into jdk/lib and then copy over. Sherman can confirm, but I believe the TzdbZoneRulesProvider requires it in the lib d

Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-01-22 Thread David Holmes
On 23/01/2013 5:52 AM, Alan Bateman wrote: On 22/01/2013 19:09, Xueming Shen wrote: Hi, Webrev has been updated to address the build issue in the new build infra. M (1) added the java.time packages into common/makefiles.javadoc/CORE_PKGS.gmk to be included into ct.sym http://cr.openjdk.java.n

Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-01-22 Thread Alan Bateman
On 22/01/2013 19:09, Xueming Shen wrote: Hi, Webrev has been updated to address the build issue in the new build infra. M (1) added the java.time packages into common/makefiles.javadoc/CORE_PKGS.gmk to be included into ct.sym http://cr.openjdk.java.net/~sherman/8003680/webrev_ctrl/ (2) not