Re: Contribution to make/Docs.gmk

2018-04-27 Thread Erik Joelsson
Looks good, I will take care of this and the other contribution. /Erik On 2018-04-27 03:31, Archana Nogriya wrote: I am looking for reviewer and sponsor for this contribution, Is anyone who can review this please and happy to sponsor for this contribution as appropriate. Hi, "make/Docs.gmk",

Contribution to make/Docs.gmk

2018-04-27 Thread Archana Nogriya
I am looking for reviewer and sponsor for this contribution, Is anyone who can review this please and happy to sponsor for this contribution as appropriate. Hi, "make/Docs.gmk", JDK_MODULES is only sorted with DOCS_MODULES, where It should also filter-out MODULES_FILTER for javadocs modules.

Contribution to make/Docs.gmk

2018-04-24 Thread Archana Nogriya
Hi, "make/Docs.gmk", JDK_MODULES is only sorted with DOCS_MODULES, where It should also filter-out MODULES_FILTER for javadocs modules. # All modules to have docs generated by docs-jdk-api target >> -JDK_MODULES := $(sort $(DOCS_MODULES)) >> +JDK_MODULES := $(sort $(filter-out $(MODULES_FILTER)

Re: Contribution to make/Docs.gmk

2018-03-11 Thread David Holmes
David Holmes To: Archana Nogriya , build-dev@openjdk.java.net Date: 08/03/2018 21:26 Subject: Re: Contribution to make/Docs.gmk Hi, On 9/03/2018 12:51 AM, Archana Nogriya wrote: Hi, In "make/Docs.gmk" We have found

Re: Contribution to make/Docs.gmk

2018-03-09 Thread Archana Nogriya
s To: Archana Nogriya , build-dev@openjdk.java.net Date: 08/03/2018 21:26 Subject: Re: Contribution to make/Docs.gmk Hi, On 9/03/2018 12:51 AM, Archana Nogriya wrote: > Hi, > > In "make/Docs.gmk" We have found 2 issues which required to be fixed in > Open

Re: Contribution to make/Docs.gmk

2018-03-08 Thread David Holmes
Hi, On 9/03/2018 12:51 AM, Archana Nogriya wrote: Hi, In "make/Docs.gmk" We have found 2 issues which required to be fixed in OpenJDK, 1) -JDK_MODULES := $(sort $(DOCS_MODULES)) +JDK_MODULES := $(sort $(filter-out $(MODULES_FILTER), $(DOCS_MODULES))) ==> This is an OpenJDK bug as this should

Re: Contribution to make/Docs.gmk

2018-03-08 Thread Erik Joelsson
Hello, On 2018-03-08 06:51, Archana Nogriya wrote: Hi, In "make/Docs.gmk" We have found 2 issues which required to be fixed in OpenJDK, 1) -JDK_MODULES := $(sort $(DOCS_MODULES)) +JDK_MODULES := $(sort $(filter-out $(MODULES_FILTER), $(DOCS_MODULES))) ==> This is an OpenJDK bug as this should

Contribution to make/Docs.gmk

2018-03-08 Thread Archana Nogriya
Hi, In "make/Docs.gmk" We have found 2 issues which required to be fixed in OpenJDK, 1) -JDK_MODULES := $(sort $(DOCS_MODULES)) +JDK_MODULES := $(sort $(filter-out $(MODULES_FILTER), $(DOCS_MODULES))) ==> This is an OpenJDK bug as this should be filtering out the MODULES_FILTER modules... he