Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13

2018-12-05 Thread Mandy Chung
Looks good. Mandy On 12/5/18 9:28 AM, joe darcy wrote: Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update:     http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in th

Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13

2018-12-05 Thread Alan Bateman
On 05/12/2018 17:28, joe darcy wrote: Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update:     http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in the build of the lib

Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13

2018-12-05 Thread joe darcy
Hi Erik, Noted; I'll update the other TEST.ROOT files in the next iteration and before this is pushed. Thanks for the review, -Joe On 12/5/2018 9:56 AM, Erik Joelsson wrote: I think jaxp and nashorn TEST.ROOT will also need to be updated. Otherwise build changes look good. /Erik On 2018

Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13

2018-12-05 Thread Erik Joelsson
I think jaxp and nashorn TEST.ROOT will also need to be updated. Otherwise build changes look good. /Erik On 2018-12-05 09:28, joe darcy wrote: Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update:     http://cr.openjdk.java.net

JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13

2018-12-05 Thread joe darcy
Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update:     http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in the build of the libraries. A new class file version is def