Re: JDK 8 code review request of langtools build changes for JDK-8014365 Restore Objects.requireNonNull(T, Supplier)

2013-05-13 Thread Erik Joelsson
Looks good to me. On 2013-05-10 23:06, Joe Darcy wrote: Hello, Please review the patch below for JDK-8014365 "Restore Objects.requireNonNull(T, Supplier)" which addresses the issue tripped over during JDK-8012344 "Backout 8011800 until langtools genstubs updated." A full build with the bel

Re: JDK 8 code review request of langtools build changes for JDK-8014365 Restore Objects.requireNonNull(T, Supplier)

2013-05-10 Thread Jonathan Gibbons
Looks good to me. -- Jon On 05/10/2013 02:06 PM, Joe Darcy wrote: Hello, Please review the patch below for JDK-8014365 "Restore Objects.requireNonNull(T, Supplier)" which addresses the issue tripped over during JDK-8012344 "Backout 8011800 until langtools genstubs updated." A full build w

JDK 8 code review request of langtools build changes for JDK-8014365 Restore Objects.requireNonNull(T, Supplier)

2013-05-10 Thread Joe Darcy
Hello, Please review the patch below for JDK-8014365 "Restore Objects.requireNonNull(T, Supplier)" which addresses the issue tripped over during JDK-8012344 "Backout 8011800 until langtools genstubs updated." A full build with the below patch to langtools and the update JDK library succeeds