Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-11 Thread Keith McGuigan
I can shepherd this through the hotspot-rt repository, where it will filter up to hotspot-main and then jdk8/hotspot. I'll make a CR for this too. http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot -- - Keith On 6/11/2012 6:10 AM, Volker Simonis wrote: Should this change be against http://

Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-11 Thread Volker Simonis
Should this change be against http://hg.openjdk.java.net/jdk8/build/hotspot or better for http://hg.openjdk.java.net/hsx/hotspot-main/hotspot? On Mon, Jun 11, 2012 at 12:01 PM, Volker Simonis wrote: > I found the problem! > > It's related to the use of precompiled headers. We need to use > '-fpch

Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-11 Thread Volker Simonis
I found the problem! It's related to the use of precompiled headers. We need to use '-fpch-deps' in order to get the full dependencies, otherwise all the dependencies from the pch file are omitted. I'm currently preparing a webrev which fixes the problem. It would be nice if somebody could meanw

Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-08 Thread Volker Simonis
Yes, that's really strange. You're right, the dependency file should contain ".. the names of all the included files" (gcc -man page). So it seems to be a bug in gcc and how it handles '-MMD' although I couldn't find a bug report for it and I can't believe that nobody else has noticed this before.

Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-08 Thread Keith McGuigan
I don't understand why gcc doesn't put frame_x86.inline.hpp into the generated/dependencies/frame.o.d file. Isn't the point of -MMD to calculate the full closer of header files used for listing as a dependency? Is this a bug in gcc or are we using it wrong? I notice that Sun Studio compile

Missing/wrong build dependencies for inline functions in HotSpot

2012-06-08 Thread Volker Simonis
Hi, I've just stumbled across the problem that changing the implementation of an inline function in HotSpot does not necessarily rebuild all the call sites of that function. This is because because of the way how the build dependencies are handled within the HotSpot. As an example you may have a l