I need a reviewer for this change:
6987107: Add NONFCS_BUILD_INFO variable to add to but not modify
MILESTONE in version string
http://javaweb.sfbay.sun.com/~ohair/webrevs/jdk7/nonfcs-version/webrev/
It removed use of JPRT_BUILD_VERSION, adds a more generic
NONFCS_BUILD_INFO.
Also
On Wed, 2010-11-24 at 11:19 -0800, Kelly O'Hair wrote:
I need a reviewer for this change:
6987107: Add NONFCS_BUILD_INFO variable to add to but not modify
MILESTONE in version string
http://javaweb.sfbay.sun.com/~ohair/webrevs/jdk7/nonfcs-version/webrev/
Bit hard to review if the host
Dang... just shoot me now. :^(
Try this:
http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
Sorry about that.
-kto
On Nov 24, 2010, at 11:28 AM, Mark Wielaard wrote:
On Wed, 2010-11-24 at 11:19 -0800, Kelly O'Hair wrote:
I need a reviewer for this change:
6987107: Add
On 11:36 Wed 24 Nov , Kelly O'Hair wrote:
Dang... just shoot me now. :^(
Try this:
http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
Sorry about that.
Looks ok to me.
I assume the motivation is so that MILESTONE doesn't have to be duplicated
in setting
On Nov 24, 2010, at 12:03 PM, Dr Andrew John Hughes wrote:
On 11:36 Wed 24 Nov , Kelly O'Hair wrote:
Dang... just shoot me now. :^(
Try this:
http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
Sorry about that.
Looks ok to me.
I assume the motivation is so that
Kelly O'Hair (kelly.oh...@oracle.com) wrote:
Dang... just shoot me now. :^(
Try this:
http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
Sorry about that.
Aren't we using the term GA (general availability) instead of FCS
these days?
Aside from that, looks fine.
-John
On Nov 24, 2010, at 3:16 PM, John Coomes wrote:
Kelly O'Hair (kelly.oh...@oracle.com) wrote:
Dang... just shoot me now. :^(
Try this:
http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
Sorry about that.
Aren't we using the term GA (general availability) instead of FCS
John Coomes said the following on 11/25/10 09:16:
Kelly O'Hair (kelly.oh...@oracle.com) wrote:
Dang... just shoot me now. :^(
Try this:
http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
Sorry about that.
Aren't we using the term GA (general availability) instead of FCS
Kelly O'Hair said the following on 11/25/10 09:55:
On Nov 24, 2010, at 3:47 PM, David Holmes wrote:
John Coomes said the following on 11/25/10 09:16:
Kelly O'Hair (kelly.oh...@oracle.com) wrote:
Dang... just shoot me now. :^(
Try this:
Kelly O'Hair said the following on 11/25/10 11:38:
On Nov 24, 2010, at 4:08 PM, David Holmes wrote:
Ok. So why not just USER_BUILD_INFO or CUSTOM_BUILD_INFO ? There's
really no tie to FCS or not. In fact why not use USER_RELEASE_SUFFIX
- see below ..
It's just a name, but we were looking for
On Nov 24, 2010, at 6:06 PM, David Holmes wrote:
Kelly O'Hair said the following on 11/25/10 11:38:
On Nov 24, 2010, at 4:08 PM, David Holmes wrote:
Ok. So why not just USER_BUILD_INFO or CUSTOM_BUILD_INFO ? There's
really no tie to FCS or not. In fact why not use
USER_RELEASE_SUFFIX -
Hi Kelly,
Logic looks fine, just a nit
Unless $(NONFCS_BUILD_INFO) really needs that leading -, I'd remove it
and add a - in line 110 and 297 below. Makes it a bit more readable
Dave
hotspot/make/defs.make
109 else
110
12 matches
Mail list logo
