Re: Need reviewer: OpenJDK7 Copyright year updates

2011-01-03 Thread Alan Bateman
Kelly O'Hair wrote: Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. I suspect you might have to run this again once the changes from all the group forests are pushed to master. That is, there might be a few files

Re: Need reviewer: OpenJDK7 Copyright year updates

2011-01-03 Thread Kelly O'Hair
On Jan 3, 2011, at 7:17 AM, Alan Bateman wrote: Kelly O'Hair wrote: Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. I suspect you might have to run this again once the changes from all the group forests are

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-29 Thread Dr Andrew John Hughes
On 15:50 Tue 28 Dec , Kelly O'Hair wrote: These changes are only adding the year 2010, to the copyright for files modified in 2010. The first year should be preserved. The pattern YEAR1, YEAR2, in the Oracle copyright line is the equivalent of the old Sun copyright year range

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-29 Thread John Yeary
Hello All, Andrew is correct. I was expecting that the copyrights would include the original and then the modified copyrights on the following lines. That has been the case with all of the companies I have worked for when we acquired companies. It has likely been changed for a while in the

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-29 Thread Kelly O'Hair
On Dec 28, 2010, at 11:13 PM, David Holmes wrote: Kelly, Kelly O'Hair said the following on 12/29/10 07:37: Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. Script used is in the top repository at make/scripts/

Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread Kelly O'Hair
Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. Script used is in the top repository at make/scripts/ update_copyright_year.sh. It finds all changesets created in 2010 and verifies that any sources with copyrights

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread John Yeary
Hello Kelly, Shouldn't the original copyrights remain in place? I see there are changes that remove Sun and replace it with Oracle on files from 1995. I would expect that code with changes should include the additional copyright for 2010. Sincerely, John Yeary On Tue, Dec 28, 2010 at 4:37 PM,

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread Kelly O'Hair
These changes are only adding the year 2010, to the copyright for files modified in 2010. The first year should be preserved. The pattern YEAR1, YEAR2, in the Oracle copyright line is the equivalent of the old Sun copyright year range YEAR1-YEAR2. So if the file originally was created in