Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-26 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/8/10 Andrew John Hughes : 2009/8/10 Kelly O'Hair : Andrew John Hughes wrote: 2009/8/10 Kelly O'Hair : Andrew John Hughes wrote: 2009/8/8 Andrew John Hughes : 2009/8/8 Kelly O'Hair : Andrew John Hughes wrote: 2009/8/8 Kelly O'Hair : Yeah. I tossed this aro

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-13 Thread Martin Buchholz
On Thu, Aug 13, 2009 at 13:33, Joseph D. Darcy wrote: > Hello. > > From my home network (no Sun VPN, etc.) I was successfully able to do a > build of jaxp after applying Kelly's patch and (after setting up the > environment a bit http://blogs.sun.com/kto/entry/anatomy_of_the_jdk_build). >  I used m

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-13 Thread Joseph D. Darcy
Andrew John Hughes wrote: 2009/8/10 Tim Bell : No luck it seems... [echo] Downloading from https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip [get] Getting: https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip [get] To: /mnt/builder/openjdk.iced

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-10 Thread Andrew John Hughes
2009/8/10 Tim Bell : > >> No luck it seems... >> >>    [echo] Downloading from >> https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip >>     [get] Getting: >> https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip >>     [get] To: >>

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-10 Thread Tim Bell
> No luck it seems... > >[echo] Downloading from > https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip > [get] Getting: > https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip > [get] To: > /mnt/builder/openjdk.icedtea/j

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-10 Thread Andrew John Hughes
2009/8/10 Andrew John Hughes : > 2009/8/10 Kelly O'Hair : >> >> Andrew John Hughes wrote: >>> >>> 2009/8/10 Kelly O'Hair : Andrew John Hughes wrote: > > 2009/8/8 Andrew John Hughes : >> >> 2009/8/8 Kelly O'Hair : >>> >>> Andrew John Hughes wrote:

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-10 Thread Andrew John Hughes
2009/8/10 Kelly O'Hair : > > Andrew John Hughes wrote: >> >> 2009/8/10 Kelly O'Hair : >>> >>> Andrew John Hughes wrote: 2009/8/8 Andrew John Hughes : > > 2009/8/8 Kelly O'Hair : >> >> Andrew John Hughes wrote: >>> >>> 2009/8/8 Kelly O'Hair : Yeah.

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-10 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/8/10 Kelly O'Hair : Andrew John Hughes wrote: 2009/8/8 Andrew John Hughes : 2009/8/8 Kelly O'Hair : Andrew John Hughes wrote: 2009/8/8 Kelly O'Hair : Yeah. I tossed this around in my head, drop seemed short and cute. ;^) Most if not all the import components

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-09 Thread Tim Bell
>> [echo] Downloading from >> https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip Kelly O'Hair wrote: > I was able to download this file from my home network fine, but > java.net downloads are not horrible reliable, the bundle may be > truncated? I suppose I should downloa

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-09 Thread Andrew John Hughes
2009/8/10 Kelly O'Hair : > > > Andrew John Hughes wrote: >> >> 2009/8/8 Andrew John Hughes : >>> >>> 2009/8/8 Kelly O'Hair : Andrew John Hughes wrote: > > 2009/8/8 Kelly O'Hair : >> >> Yeah. I tossed this around in my head, drop seemed short and cute. ;^) >> Most if no

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-09 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/8/8 Andrew John Hughes : 2009/8/8 Kelly O'Hair : Andrew John Hughes wrote: 2009/8/8 Kelly O'Hair : Yeah. I tossed this around in my head, drop seemed short and cute. ;^) Most if not all the import components are tools used to do the build but not sources that

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-09 Thread Andrew John Hughes
2009/8/8 Andrew John Hughes : > 2009/8/8 Kelly O'Hair : >> >> >> Andrew John Hughes wrote: >>> >>> 2009/8/8 Kelly O'Hair : Yeah. I tossed this around in my head, drop seemed short and cute. ;^) Most if not all the import components are tools used to do the build but not sources

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Andrew John Hughes
2009/8/8 Kelly O'Hair : > > > Andrew John Hughes wrote: >> >> 2009/8/8 Kelly O'Hair : >>> >>> Yeah. I tossed this around in my head, drop seemed short and cute. ;^) >>> Most if not all the import components are tools used to do the build >>> but not sources that became part of the product built bit

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/8/8 Kelly O'Hair : Yeah. I tossed this around in my head, drop seemed short and cute. ;^) Most if not all the import components are tools used to do the build but not sources that became part of the product built bits. Maybe the IcedTea guys can chime in on this

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Joe Darcy
Andrew John Hughes wrote: 2009/8/8 Kelly O'Hair : Yeah. I tossed this around in my head, drop seemed short and cute. ;^) Most if not all the import components are tools used to do the build but not sources that became part of the product built bits. Maybe the IcedTea guys can chime in on this.

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Andrew John Hughes
2009/8/8 Kelly O'Hair : > Yeah. I tossed this around in my head, drop seemed short and cute. ;^) > Most if not all the import components are tools used to do the build > but not sources that became part of the product built bits. > > Maybe the IcedTea guys can chime in on this. > > I'm happy to cha

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Kelly O'Hair
Yeah. I tossed this around in my head, drop seemed short and cute. ;^) Most if not all the import components are tools used to do the build but not sources that became part of the product built bits. Maybe the IcedTea guys can chime in on this. I'm happy to change it to another name that makes m

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Tim Bell
Kelly O'Hair wrote: > Most of the targets (all included) are in the ant script, and listed > in ANT_TARGETS. So 'make all' runs 'ant all'. Ah - of course. Now I see it. So this is a very thin Makefile around ant. That is where the world has been headed for quite a while, I guess... Tim

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Jonathan Gibbons
Well, elsewhere in the JDK build, the name "import" seems to cover the same concept of inbound stuff from outside the repository. But, I know you do similar stuff in the FX world, so I wasn't sure if "drop" came from there. -- Jon Kelly O'Hair wrote: --- The drop name just dropped into m

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Kelly O'Hair
Tim Bell wrote: Hi Kelly: Need reviewers: 6856630: Restructure jaxp/jaxws repositories Webrev: http://cr.openjdk.java.net/~ohair/jdk7/jaxp-6856630/webrev/ make/Makefile Your new version has: 108 default: all : : 168 jprt_build_product jprt_build_debug jprt_build_fastdebug: all But I

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Tim Bell
Hi Kelly: > Need reviewers: > > 6856630: Restructure jaxp/jaxws repositories > > Webrev: http://cr.openjdk.java.net/~ohair/jdk7/jaxp-6856630/webrev/ make/Makefile Your new version has: 108 default: all : : 168 jprt_build_product jprt_build_debug jprt_build_fastdebug: all But I can't find

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Kelly O'Hair
It's still there. javac.debug=true is the default, so the lines: 44 ifeq ($(VARIANT), OPT) 45 ifneq ($(DEBUG_CLASSFILES), true) 46 ANT_OPTIONS += -Djavac.debug=false 47 endif 48 endif Only set it to false when the build is optimized and DEBUG_CLASSFILES isn't true. So the end

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Jonathan Gibbons
You've lost these lines: I thought it was a goal to support DEBUG_CLASSFILES in all repos 72 ifeq ($(DEBUG_CLASSFILES), true) 73 ANT_OPTIONS += -Djavac.debug=true 74 endif Is the "drop" name a standard convention, as compared to, say, "import"? -- Jon Kelly O'Hair wrote: Need review

Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Kelly O'Hair
Need reviewers: 6856630: Restructure jaxp/jaxws repositories Webrev: http://cr.openjdk.java.net/~ohair/jdk7/jaxp-6856630/webrev/ Goal is to ease the jaxp integration into jdk7. The JAXP team would make the jdk7 source drop bundles available, and integration into jdk7 would involve the modifica