Re: New project: getting rid of IcedTea local patches

2009-04-18 Thread Andrew Haley
Martin Buchholz wrote: > On Sat, Apr 18, 2009 at 02:50, Andrew Haley wrote: >> Martin Buchholz wrote: >> Well, maintaining this "buffer" forest is, more or less, what IcedTea does. >> I'm not sure that we need another one. > > I wasn't suggesting we start a new buffer forest. > I was suggesting w

Re: New project: getting rid of IcedTea local patches

2009-04-18 Thread Martin Buchholz
On Sat, Apr 18, 2009 at 02:50, Andrew Haley wrote: > Martin Buchholz wrote: > Well, maintaining this "buffer" forest is, more or less, what IcedTea does. > I'm not sure that we need another one. I wasn't suggesting we start a new buffer forest. I was suggesting we (Google + IcedTea) consider shar

Re: New project: getting rid of IcedTea local patches

2009-04-18 Thread Andrew Haley
Martin Buchholz wrote: > On Thu, Apr 9, 2009 at 06:14, Andrew Haley wrote: >> Andrew Haley wrote: >>> We at Red Hat have noticed that the list of IcedTea local patches has >>> been getting large, with some local patches that should have been >>> pushed upstream. Also, some IcedTea patches have be

Re: New project: getting rid of IcedTea local patches

2009-04-17 Thread Martin Buchholz
On Thu, Apr 9, 2009 at 06:14, Andrew Haley wrote: > Andrew Haley wrote: >> We at Red Hat have noticed that the list of IcedTea local patches has >> been getting large, with some local patches that should have been >> pushed upstream.  Also, some IcedTea patches have been committed to >> OpenJDK 7

Re: New project: getting rid of IcedTea local patches

2009-04-16 Thread Joseph D. Darcy
Catching up on email, Andrew John Hughes wrote: 2009/4/9 Alan Bateman : Andrew Haley wrote: [snip] I'm not very familiar with IcedTea but I cloned the repository to see what these patches are about. Here are a few comments: icedtea-6728542-epoll.patch seems to be a change-set I push

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Alan Bateman
Andrew Haley wrote: Andrew John Hughes wrote: 2009/4/9 Alan Bateman : icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already handled this case so I'm curious why this one is needed. Added by Andrew Haley as part of work on Shark; perhaps he can explain.

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew John Hughes
2009/4/9 Alan Bateman : > Andrew John Hughes wrote: >> >> : >>> >>> icedtea-bytebuffer-compact.patch - this looks to be a partial fix to >>> 6593946. If so, 6593946 is already in jdk6/jdk6/jdk >>> (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). >>> >>> >> >> IcedTea6 is still based on

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Alan Bateman
Andrew John Hughes wrote: : icedtea-bytebuffer-compact.patch - this looks to be a partial fix to 6593946. If so, 6593946 is already in jdk6/jdk6/jdk (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). IcedTea6 is still based on the last build drop of jdk6, not the Mercurial repo

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew Haley
Andrew John Hughes wrote: > 2009/4/9 Alan Bateman : >> icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already >> handled this case so I'm curious why this one is needed. > > Added by Andrew Haley as part of work on Shark; perhaps he can explain. GetLineNumberTable checks for a m

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew John Hughes
2009/4/9 Andrew John Hughes : > 2009/4/9 Alan Bateman : >> Andrew Haley wrote: >>> >>> : >>> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >>> These are the patches in icedtea/patches and icedtea/patches/hotspot. >>> >>> >>> * Every patch should be assigned to someone. >>> >

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew John Hughes
2009/4/9 Alan Bateman : > Andrew Haley wrote: >> >> : >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >> These are the patches in icedtea/patches and icedtea/patches/hotspot. >> >> >> * Every patch should be assigned to someone. >> >> * Every patch should be discussed. >> >

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew John Hughes
2009/4/1 Joseph D. Darcy : > Andrew Haley wrote: >> >> We at Red Hat have noticed that the list of IcedTea local patches has >> been getting large, with some local patches that should have been >> pushed upstream.  Also, some IcedTea patches have been committed to >> OpenJDK 7 but not OpenJDK 6. >>

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Matthias Klose
Andrew Haley schrieb: > The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches > SCA: Enter "OK" here if you are certain that all authors of this patch have an > SCA on file. this is not correct. AFAIU all authors of the patch have to submit the patch under the SCA, just having an

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew Haley
Matthias Klose wrote: > Andrew Haley schrieb: >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches > >> SCA: Enter "OK" here if you are certain that all authors of this patch have >> an >> SCA on file. > > this is not correct. AFAIU all authors of the patch have to submit the

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew John Hughes
2009/4/9 Alan Bateman : > Andrew Haley wrote: >> >> : >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >> These are the patches in icedtea/patches and icedtea/patches/hotspot. >> >> >> * Every patch should be assigned to someone. >> >> * Every patch should be discussed. >> >

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Alan Bateman
Andrew Haley wrote: : The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches These are the patches in icedtea/patches and icedtea/patches/hotspot. * Every patch should be assigned to someone. * Every patch should be discussed. * If we can, we will push a patch upstream. If we

Re: New project: getting rid of IcedTea local patches

2009-04-09 Thread Andrew Haley
Andrew Haley wrote: > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream. Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a serious

Re: New project: getting rid of IcedTea local patches

2009-04-06 Thread Gary Benson
Christian Thalinger wrote: > On Wed, 2009-04-01 at 11:33 -0700, Kelly O'Hair wrote: > > The changes to the jdk files look fine. One question though, does > > the name "CORE_BUILD" have a meaning to the JDK, or just the VM? > > Just wondering if a "VM_CORE_BUILD" or "HOTSPOT_CORE_BUILD" might > > b

Re: New project: getting rid of IcedTea local patches

2009-04-03 Thread Dalibor Topic
Andrew Haley wrote: > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream. Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a serious

Re: New project: getting rid of IcedTea local patches

2009-04-02 Thread Kelly O'Hair
Christian Thalinger wrote: On Wed, 2009-04-01 at 11:33 -0700, Kelly O'Hair wrote: The changes to the jdk files look fine. One question though, does the name "CORE_BUILD" have a meaning to the JDK, or just the VM? Just wondering if a "VM_CORE_BUILD" or "HOTSPOT_CORE_BUILD" might be a better nam

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Christian Thalinger
On Wed, 2009-04-01 at 11:33 -0700, Kelly O'Hair wrote: > The changes to the jdk files look fine. > One question though, does the name "CORE_BUILD" have a meaning to the > JDK, or just the VM? Just wondering if a "VM_CORE_BUILD" or > "HOTSPOT_CORE_BUILD" might be a better name. Not a big deal. I do

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Andrew John Hughes
2009/4/1 Kelly O'Hair : > > Andrew John Hughes wrote: >> >> 2009/4/1 Andrew John Hughes : >>> >>> 2009/4/1 Kelly O'Hair : Andrew Haley wrote: > > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should hav

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/4/1 Andrew John Hughes : 2009/4/1 Kelly O'Hair : Andrew Haley wrote: We at Red Hat have noticed that the list of IcedTea local patches has been getting large, with some local patches that should have been pushed upstream. Also, some IcedTea patches have been co

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Kelly O'Hair
Christian Thalinger wrote: On Wed, 2009-04-01 at 10:47 -0700, Kelly O'Hair wrote: I can certainly help out with any build related (makefiles etc.) changes. Ohh, that reminds me of this one: https://bugs.openjdk.java.net/show_bug.cgi?id=100011 Because one change touches a jdk Makefile, I did

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Christian Thalinger
On Wed, 2009-04-01 at 10:47 -0700, Kelly O'Hair wrote: > I can certainly help out with any build related (makefiles etc.) > changes. Ohh, that reminds me of this one: https://bugs.openjdk.java.net/show_bug.cgi?id=100011 Because one change touches a jdk Makefile, I didn't push yet. Either someon

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Andrew John Hughes
2009/4/1 Andrew Haley : > Andrew John Hughes wrote: >> 2009/4/1 Kelly O'Hair : >>> >>> I can certainly help out with any build related (makefiles etc.) >>> changes. >> >> Good, because to my knowledge, those form the majority :) >> However, my guess would also be that some require extensive reworki

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Andrew John Hughes
2009/4/1 Andrew John Hughes : > 2009/4/1 Kelly O'Hair : >> Andrew Haley wrote: >>> >>> We at Red Hat have noticed that the list of IcedTea local patches has >>> been getting large, with some local patches that should have been >>> pushed upstream.  Also, some IcedTea patches have been committed to

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Andrew Haley
Andrew John Hughes wrote: > 2009/4/1 Kelly O'Hair : >> >> I can certainly help out with any build related (makefiles etc.) >> changes. > > Good, because to my knowledge, those form the majority :) > However, my guess would also be that some require extensive reworking > to be generally acceptable

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Andrew John Hughes
2009/4/1 Kelly O'Hair : > Andrew Haley wrote: >> >> We at Red Hat have noticed that the list of IcedTea local patches has >> been getting large, with some local patches that should have been >> pushed upstream.  Also, some IcedTea patches have been committed to >> OpenJDK 7 but not OpenJDK 6. >> >>

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Kelly O'Hair
Andrew Haley wrote: We at Red Hat have noticed that the list of IcedTea local patches has been getting large, with some local patches that should have been pushed upstream. Also, some IcedTea patches have been committed to OpenJDK 7 but not OpenJDK 6. So, we're going to have a serious attempt t

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Joseph D. Darcy
Andrew Haley wrote: We at Red Hat have noticed that the list of IcedTea local patches has been getting large, with some local patches that should have been pushed upstream. Also, some IcedTea patches have been committed to OpenJDK 7 but not OpenJDK 6. So, we're going to have a serious attempt t

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Andrew John Hughes
2009/4/1 Andrew Haley : > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream.  Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a seri

New project: getting rid of IcedTea local patches

2009-04-01 Thread Andrew Haley
We at Red Hat have noticed that the list of IcedTea local patches has been getting large, with some local patches that should have been pushed upstream. Also, some IcedTea patches have been committed to OpenJDK 7 but not OpenJDK 6. So, we're going to have a serious attempt to minimize the number