Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Kelly O'Hair
Looks good Tim. I wish that freetype just had a simple version.h file we could check. :^( -kto Tim Bell wrote: Hi Folks When building OpenJDK, the freetype sanity check compiles a little program to test that the freetype include files and libraries are available, and also that the version

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Tim Bell
Kelly O'Hair wrote: Looks good Tim. Thanks, Kelly. I plan to push this fix to the build forest later today. I wish that freetype just had a simple version.h file we could check. :^( I checked the freetype 2.3.5 include files... we could use this from include/freetype/freetype.h:

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Kelly O'Hair
Humm... as much as building a freetype application tells us that the libraries work, I'm wondering if we could just do something like this in the makefile sanity check: ifdef OPENJDK FREETYPE_VERSION_H=$(FREETYPE_HEADERS_PATH)/freetype/freetype.h _FREETYPE_VER := \ if [ -f

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Martin Buchholz
A way to check at runtime, since freetype 2.0.9, is - A new function named `FT_Library_Version' has been added to return the current library's major, minor, and patch version numbers. This is important since the macros FREETYPE_MAJOR, FREETYPE_MINOR, and

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Tim Bell
Hi Martin A way to check at runtime, since freetype 2.0.9, is - A new function named `FT_Library_Version' has been added to return the current library's major, minor, and patch version numbers. This is important since the macros FREETYPE_MAJOR,

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Igor Nekrestyanov
Martin Buchholz wrote: A way to check at runtime, since freetype 2.0.9, is - A new function named `FT_Library_Version' has been added to return the current library's major, minor, and patch version numbers. This is important since the macros FREETYPE_MAJOR,

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Kelly O'Hair
Tim Bell wrote: Hi Kelly- Just a thought Then that whole freetype check program can go away, but if the libraries are wrong, we won't find out at sanity check time. Good idea. but we will have to take it up under a new Bug-ID. I had already started my push when I saw your email. I

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Tim Bell
Hi Martin Well, I have to side with Microsoft on this one. So do I, actually. The O/S directories should be read-only. I take issue with the alternative presented to developers and ISVs all over the world, which is that they must redistribute the runtime with their product. Everyone has to

Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-20 Thread Tim Bell
Hi Folks When building OpenJDK, the freetype sanity check compiles a little program to test that the freetype include files and libraries are available, and also that the version number is acceptable. If building on Windows and using a Visual Studio compiler newer than 2003, this program will