Andrew,
Dr Andrew John Hughes said the following on 03/09/11 03:24:
On 10:51 Tue 08 Mar , David Holmes wrote:
Just to clarify for people, BUILD_CLIENT_ONLY refers to building the client VM
only.
Some of these variables should be documented in the top level
README-builds.html file, but tha
FYI I accidentally nuked all my webrevs on cr.openjdk.jav.net.
I'll send out new review requests and webrevs next week.
David
David Holmes said the following on 03/11/11 11:50:
Dr Andrew John Hughes said the following on 03/11/11 11:02:
On 17:35 Thu 10 Mar , David Holmes wrote:
Sorry, thi
Dr Andrew John Hughes said the following on 03/11/11 11:02:
On 17:35 Thu 10 Mar , David Holmes wrote:
Sorry, this was just a preliminary RFR so I didn't set up the webrev
versioning.
My issue was more a personal distaste for webrevs than anything you did
wrong. I just find it much easie
On 17:35 Thu 10 Mar , David Holmes wrote:
> Dr Andrew John Hughes said the following on 03/10/11 10:26:
> > On 22:09 Wed 09 Mar , David Holmes wrote:
> >> My original reply does not seem to have made it to build-dev.
> >>
> >> I've updated the webrev again to accommodate openjdk builds that
Dr Andrew John Hughes said the following on 03/10/11 10:26:
On 22:09 Wed 09 Mar , David Holmes wrote:
My original reply does not seem to have made it to build-dev.
I've updated the webrev again to accommodate openjdk builds that set
REDUCED_JRE and/or REDUCED_HEADLESS_JRE. The main changes
On 22:09 Wed 09 Mar , David Holmes wrote:
> My original reply does not seem to have made it to build-dev.
>
> I've updated the webrev again to accommodate openjdk builds that set
> REDUCED_JRE and/or REDUCED_HEADLESS_JRE. The main changes are:
>
Another problem with these webrevs is that yo
On 09:33 Wed 09 Mar , David Holmes wrote:
> Andrew,
>
> Dr Andrew John Hughes said the following on 03/09/11 03:24:
> > On 10:51 Tue 08 Mar , David Holmes wrote:
> Just to clarify for people, BUILD_CLIENT_ONLY refers to building the
> client VM only.
> Some of these variabl
My original reply does not seem to have made it to build-dev.
I've updated the webrev again to accommodate openjdk builds that set
REDUCED_JRE and/or REDUCED_HEADLESS_JRE. The main changes are:
- don't try to run freetypecheck when cross-compiling
- delete build of freetypecheck from make/tool
On 10:51 Tue 08 Mar , David Holmes wrote:
> Andrew,
>
> Many thanks for the feedback:
>
> Dr Andrew John Hughes said the following on 03/08/11 04:30:
> > On 09:39 Mon 07 Mar , Kelly O'Hair wrote:
> >
> > General comments:
> >
> > * Could this not be broken up into smaller changesets to
Can the echo in Library.gmk be changed to @$(ECHO) ?
Otherwise I'm ok with these changes.
-kto
On Mar 8, 2011, at 3:39 AM, David Holmes wrote:
> I've updated the webrev - same location:
>
> http://cr.openjdk.java.net/~dholmes/7025066/webrev/
>
> The main section for SE-Embedded is in Defs.gmk
I've updated the webrev - same location:
http://cr.openjdk.java.net/~dholmes/7025066/webrev/
The main section for SE-Embedded is in Defs.gmk as there were some
dependencies on settings created in other gmk files. A few files are no
longer changed and I removed some unnecessary checks (ie that
On Mar 7, 2011, at 4:32 PM, David Holmes wrote:
> Kelly,
>
> Many thanks for the comments.
>
> I could try to lift a single use of JAVASE_EMBEDDED up to the top-level to
> control things like: COMPRESS_JARS=true/false; REDUCED_JRE etc. In which, of
> the many, makefiles would you suggest plac
Andrew,
Many thanks for the feedback:
Dr Andrew John Hughes said the following on 03/08/11 04:30:
On 09:39 Mon 07 Mar , Kelly O'Hair wrote:
General comments:
* Could this not be broken up into smaller changesets to make it easier to
review and catch regressions?
In theory probably, in
Kelly,
Many thanks for the comments.
I could try to lift a single use of JAVASE_EMBEDDED up to the top-level
to control things like: COMPRESS_JARS=true/false; REDUCED_JRE etc. In
which, of the many, makefiles would you suggest placing this? In the
case of COMPRESS_JARS would you want this to
On 09:39 Mon 07 Mar , Kelly O'Hair wrote:
General comments:
* Could this not be broken up into smaller changesets to make it easier to
review and catch regressions?
* There seem to be some whitespace changes that shouldn't be there.
e.g.
- sane-msvcrt_path \
+ sane-msvcrt_path
Just to clarify for people, BUILD_CLIENT_ONLY refers to building the client VM
only.
Some of these variables should be documented in the top level
README-builds.html file, but that
can be done under a separate CR if necessary.
The Library.gmk file seems like it is just a leftover debugging echo?
http://cr.openjdk.java.net/~dholmes/7025066/webrev/
The SE-Embedded product is a combination of open and closed sources. To
allow SE-Embedded to be built from standard OpenJDK sources we need to
apply a number of changes to the SE 7 build system:
- support for building the hotspot client comp
17 matches
Mail list logo
