Re: RFC: architecture define probably masks variable names in header files

On Wed, 2008-01-16 at 23:04 +0100, Christian Thalinger wrote: > Hi! > > Today I noticed that it's not a good idea to use an architecture define > as done in OpenJDK: > > CPPFLAGS_COMMON = -D$(ARCH) -DARCH='"$(ARCH)"' -DLINUX $(VERSION_DEFINES) \ > -D_LARGEFILE64_SOURCE -D_GNU_SOUR

Re: RFC: architecture define probably masks variable names in header files

Christian, I care, and agree with you. I recall many years ago, debugging a mysterious failure building Emacs. Building on Solaris-Sparc defined the symbol "sparc", and this caused the build to fail, only if a component of the current working directory was "sparc". Martin Christian Thalinger wr

Re: RFC: architecture define probably masks variable names in header files

I very much suspect that this -D$(ARCH) could be removed with no consequences. The difficult part would be verifying it. C macros are a very powerful tool, but some of the global names we have chosen over the years have come back to haunt us. :^( -kto Martin Buchholz wrote: Christian, I care,

RE: RFC: architecture define probably masks variable names in header files

ED] [mailto:build-dev- > [EMAIL PROTECTED] On Behalf Of Christian Thalinger > Sent: Monday, January 21, 2008 8:37 AM > To: build-dev > Subject: Re: RFC: architecture define probably masks variable names in > header files > > On Wed, 2008-01-16 at 23:04 +0100, Christian Thalinger w

RE: RFC: architecture define probably masks variable names in header files

On Wed, 2008-01-23 at 11:14 -0800, Ted Neward wrote: > This may be an area where you have to implement the fix and submit it as a > patch, because I can see the developers at Sun not having the bandwidth to > take time away from the other things they're working on to take care of this > themselves-

Re: RFC: architecture define probably masks variable names in header files

On Wed, 2008-01-23 at 11:04 -0800, Kelly O'Hair wrote: > I very much suspect that this -D$(ARCH) could be removed with no consequences. > The difficult part would be verifying it. > > C macros are a very powerful tool, but some of the global names we have chosen > over the years have come back to

RE: RFC: architecture define probably masks variable names in header files

er [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 23, 2008 1:20 PM > To: Ted Neward > Cc: 'build-dev' > Subject: RE: RFC: architecture define probably masks variable names in > header files > > On Wed, 2008-01-23 at 11:14 -0800, Ted Neward wrote: > > Thi

Re: RFC: architecture define probably masks variable names in header files

ger [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 23, 2008 1:20 PM To: Ted Neward Cc: 'build-dev' Subject: RE: RFC: architecture define probably masks variable names in header files On Wed, 2008-01-23 at 11:14 -0800, Ted Neward wrote: This may be an area where you have to implement

Re: RFC: architecture define probably masks variable names in header files

the native code is usually in the src/solaris, src/windows, src/linux, and src/share directories. But to be safe you might want to create a complete list from the root of the repository forest with: find . -type f -name \*.c -o -name \*.h -o -name \*.cpp -o -name \*.hpp Maybe with a little di

Re: RFC: architecture define probably masks variable names in header files

Kelly O'Hair wrote: I very much suspect that this -D$(ARCH) could be removed with no consequences. The difficult part would be verifying it. C macros are a very powerful tool, but some of the global names we have chosen over the years have come back to haunt us. :^( src/solaris/hpi/native_t

Re: RFC: architecture define probably masks variable names in header files

Kelly O'Hair wrote: I very much suspect that this -D$(ARCH) could be removed with no consequences. The difficult part would be verifying it. C macros are a very powerful tool, but some of the global names we have chosen over the years have come back to haunt us. :^( src/solaris/hpi/native_t

Re: RFC: architecture define probably masks variable names in header files

If it's not used, I say OFF WITH IT"S HEAD! ;^) -kto Alan Bateman wrote: Kelly O'Hair wrote: I very much suspect that this -D$(ARCH) could be removed with no consequences. The difficult part would be verifying it. C macros are a very powerful tool, but some of the global names we have cho

Re: RFC: architecture define probably masks variable names in header files

Actually, I recall that one of the things we've always wanted to do is get rid of HPI. Never seems to be important enough. Paul Kelly O'Hair wrote: If it's not used, I say OFF WITH IT"S HEAD! ;^) -kto Alan Bateman wrote: Kelly O'Hair wrote: I very much suspect that this -D$(ARCH) could be

Re: RFC: architecture define probably masks variable names in header files

Hi, Paul. You recall correctly. We've wanted to remove the entire HPI layer since at least 1.3 but it's never been high enough priority, particularly given that we expect it to be a non-trivial task. New APIs (e.g. java.nio) were explicitly written to avoid using it, but a number of old APIs st

RE: RFC: architecture define probably masks variable names in header files

rsday, January 24, 2008 4:40 PM > To: [EMAIL PROTECTED] > Cc: build-dev@openjdk.java.net; [EMAIL PROTECTED]; iris clark > Subject: Re: RFC: architecture define probably masks variable names in > header files > > > Hi, Paul. > > You recall correctly. We've wanted to