Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-30 Thread Dmitry Samersoff
John, Actually the goal of my letter is not to promote new integration scheme. Just to remind that we need to put some efforts to internal process review and optimization. But, see answers below (inline): Integration method I mentioned often used in open source projects, because it doesn't

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-30 Thread Robert Ottenhag
Dmitry, I think this discussion diverged somewhat from the original topic, but I do agree with you that we must also attack the problem on a process level. With the model you propose (and also the existing model) I would also like to stress the need for continuous and automatic builds

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-30 Thread Kelly O'Hair
Diverged and in transit to another planet. :^( A push to a shared repo without verifying it builds on all supported platforms is risky behavior, and one that can consume needless resources finding out it doesn't build, and more importantly waste your co-worker's time undoing it. We have the

RE: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-30 Thread Robert Ottenhag
Inline, -Original Message- From: Kelly O'Hair Sent: Monday, January 30, 2012 6:27 PM To: Robert Ottenhag Cc: Dmitry Samersoff; serviceability-...@openjdk.java.net; John Coomes; build-dev@openjdk.java.net Subject: Re: RFR: 7133124 Remove redundant packages from JAR command line

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-30 Thread Jonathan Gibbons
On 01/30/2012 09:41 AM, Robert Ottenhag wrote: A push to a shared repo without verifying it builds on all supported platforms is risky behavior, and one that can consume needless resources finding out it doesn't build, and more importantly waste your co-worker's time undoing it. We

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-30 Thread Jonathan Gibbons
On 01/30/2012 03:41 PM, Kelly O'Hair wrote: I also think that extremely low or no risk changes need not follow this rule, but the problem is getting people to agree with 'no risk changes' are. I've seen enough 'low risk' changes bring the house down that I'm on the paranoid side. :^( How

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-30 Thread Kelly O'Hair
: 7133124 Remove redundant packages from JAR command line Diverged and in transit to another planet. :^( A push to a shared repo without verifying it builds on all supported platforms is risky behavior, and one that can consume needless resources finding out it doesn't build, and more importantly

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-29 Thread Georges Saab
On 28 jan 2012, at 09:46, Kelly O'Hair wrote: On Jan 27, 2012, at 9:52 PM, Georges Saab wrote: On 27 jan 2012, at 12:40, Kelly O'Hair wrote: On Jan 26, 2012, at 2:47 PM, Georges Saab wrote: As long as we target both 7u and 8 we will be using two different toolsets. But I agree

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-29 Thread Kelly O'Hair
On Jan 29, 2012, at 10:23 AM, Georges Saab wrote: I'm missing something. How can everybody using the exact same system scale to 100's of developers? System = distributed build and test of OpenJDK Ah ha... I'm down in the trenches dealing with dozens of different OS's arch's variation

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-29 Thread Dmitry Samersoff
Kelly, The serialize checkins issue can be minimized some by using distributed SCMs (Mercurial, Git, etc) We have chosen a model: build-test-integrate but we may consider different approach: integrate-build-test-[backout if necessary] i.e. Developer (A) integrate his changeset to an

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-29 Thread John Coomes
Dmitry Samersoff (dmitry.samers...@oracle.com) wrote: Kelly, The serialize checkins issue can be minimized some by using distributed SCMs (Mercurial, Git, etc) We have chosen a model: build-test-integrate but we may consider different approach: integrate-build-test-[backout if

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-28 Thread Kelly O'Hair
On Jan 27, 2012, at 9:52 PM, Georges Saab wrote: On 27 jan 2012, at 12:40, Kelly O'Hair wrote: On Jan 26, 2012, at 2:47 PM, Georges Saab wrote: As long as we target both 7u and 8 we will be using two different toolsets. But I agree that JPRT and RE should be using the same tools.

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-27 Thread Kelly O'Hair
On Jan 26, 2012, at 2:47 PM, Georges Saab wrote: As long as we target both 7u and 8 we will be using two different toolsets. But I agree that JPRT and RE should be using the same tools. That needs to be taken up with RE and Kelly. Ideally not just using the same tools, but they should

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-27 Thread Georges Saab
On 27 jan 2012, at 12:40, Kelly O'Hair wrote: On Jan 26, 2012, at 2:47 PM, Georges Saab wrote: As long as we target both 7u and 8 we will be using two different toolsets. But I agree that JPRT and RE should be using the same tools. That needs to be taken up with RE and Kelly.

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Alan Bateman
On 26/01/2012 09:44, Rickard Bäckman wrote: Hi, We have a problem with some versions of jar reporting errors when trying to run jar cf some.jar com/test com/test/foo This fix removes the redundant subdirectories from the command. Webrev is here:

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Rickard Bäckman
On 01/26/2012 10:51 AM, Alan Bateman wrote: On 26/01/2012 09:44, Rickard Bäckman wrote: Hi, We have a problem with some versions of jar reporting errors when trying to run jar cf some.jar com/test com/test/foo This fix removes the redundant subdirectories from the command. Webrev is here:

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread David Holmes
On 26/01/2012 7:44 PM, Rickard Bäckman wrote: We have a problem with some versions of jar reporting errors when trying to run jar cf some.jar com/test com/test/foo This fix removes the redundant subdirectories from the command. Webrev is here:

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Rickard Bäckman
On 01/26/2012 12:50 PM, David Holmes wrote: On 26/01/2012 7:44 PM, Rickard Bäckman wrote: We have a problem with some versions of jar reporting errors when trying to run jar cf some.jar com/test com/test/foo This fix removes the redundant subdirectories from the command. Webrev is here:

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Rickard Bäckman
On 01/26/2012 12:53 PM, Karen Kinnear wrote: Code change looks good. I assume you want to put this fix back to JDK8 as well. thank you for the quick fix! Karen Thanks for the review Karen, I'm not sure about JDK8, I think it build with JDK1.7.0? Which has a fixed version of jar. I'll try

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Rickard Bäckman
Karen, that makes sense, I'll push to 8 as well. Thanks /R On 01/26/2012 01:20 PM, Karen Kinnear wrote: Thanks Rickard. My guess is that if it works with all version of jar which you've tested, then it will be easier going forward to maintain the file consistently, and it causes no harm.

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Paul Hohensee
Will this fix the jdk7u-dev build problem? Thanks, paul On 1/26/12 4:44 AM, Rickard Bäckman wrote: Hi, We have a problem with some versions of jar reporting errors when trying to run jar cf some.jar com/test com/test/foo This fix removes the redundant subdirectories from the command.

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Paul Hohensee
Apparently yes. Thanks, paul On 1/26/12 9:14 AM, Paul Hohensee wrote: Will this fix the jdk7u-dev build problem? Thanks, paul On 1/26/12 4:44 AM, Rickard Bäckman wrote: Hi, We have a problem with some versions of jar reporting errors when trying to run jar cf some.jar com/test

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Karen Kinnear
Thanks Rickard. My guess is that if it works with all version of jar which you've tested, then it will be easier going forward to maintain the file consistently, and it causes no harm. thanks, Karen On Jan 26, 2012, at 7:03 AM, Rickard Bäckman wrote: On 01/26/2012 12:53 PM, Karen Kinnear

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Karen Kinnear
Code change looks good. I assume you want to put this fix back to JDK8 as well. thank you for the quick fix! Karen On Jan 26, 2012, at 4:44 AM, Rickard Bäckman wrote: Hi, We have a problem with some versions of jar reporting errors when trying to run jar cf some.jar com/test com/test/foo

RE: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Markus Grönlund
Thanks Alan for quick response, much appreciated. Markus -Original Message- From: Alan Bateman Sent: den 26 januari 2012 10:52 To: Rickard Bäckman Cc: serviceability-...@openjdk.java.net; build-dev@openjdk.java.net Subject: Re: RFR: 7133124 Remove redundant packages from JAR

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread David Holmes
On 26/01/2012 10:37 PM, Rickard Bäckman wrote: Karen, that makes sense, I'll push to 8 as well. Recall that I plan to change all this by moving it into make/closed for 8 (and then 7u). So this could be cleaned up then. David - Thanks /R On 01/26/2012 01:20 PM, Karen Kinnear wrote:

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread David Holmes
On 26/01/2012 10:02 PM, Rickard Bäckman wrote: On 01/26/2012 12:50 PM, David Holmes wrote: Change looks fine, but then so did the original! Will this be handled correctly by all versions of the jar command? We, have checked the contents of the version that RE is using (1.6.0_1 or something

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Georges Saab
On 26 jan 2012, at 13:56, David Holmes wrote: On 26/01/2012 10:02 PM, Rickard Bäckman wrote: On 01/26/2012 12:50 PM, David Holmes wrote: Change looks fine, but then so did the original! Will this be handled correctly by all versions of the jar command? We, have checked the contents of the