Re: RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-25 Thread Erik Joelsson
On 2018-05-25 01:21, Magnus Ihse Bursie wrote: On 2018-05-16 16:18, Magnus Ihse Bursie wrote: 16 maj 2018 kl. 01:39 skrev Erik Joelsson: Hello, In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice. Oops, will fix. Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we shoul

Re: RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-25 Thread Magnus Ihse Bursie
On 2018-05-16 16:18, Magnus Ihse Bursie wrote: 16 maj 2018 kl. 01:39 skrev Erik Joelsson : Hello, In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice. Oops, will fix. Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we should be moving them to one place? Regardless, I th

Re: RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-16 Thread Magnus Ihse Bursie
> 16 maj 2018 kl. 01:39 skrev Erik Joelsson : > > Hello, > > In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice. Oops, will fix. > Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we > should be moving them to one place? Regardless, I think we need an INCLUDE in > the S

RE: RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-15 Thread Markus Gronlund
Magnus and Erik, Big thanks in regards to your ongoing assistance and follow-up on this. Best regards Markus and Erik (G) -Original Message- From: Magnus Ihse Bursie Sent: den 16 maj 2018 01:14 To: build-dev ; hotspot-jfr-...@openjdk.java.net Subject: RFR: JDK-8203221 Makefile fixes aft

Re: RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-15 Thread Erik Joelsson
Hello, In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice. Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we should be moving them to one place? Regardless, I think we need an INCLUDE in the SetupJavaCompilation so that we only build the tool we need. There is currently