Dan
The changes look good
Ron
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Wednesday, February 05, 2014 4:21 PM
> To: hotspot-runtime-...@openjdk.java.net;
> serviceability-...@openjdk.java.net; build-dev;
> Doug Simon; Tom Rodriguez
> Subject: code review round 0 for minor
Ron,
Thanks for the review.
Dan
On 2/5/14 7:04 PM, Ron Durbin wrote:
Dan
The changes look good
Ron
-Original Message-
From: Daniel D. Daugherty
Sent: Wednesday, February 05, 2014 4:21 PM
To: hotspot-runtime-...@openjdk.java.net; serviceability-...@openjdk.java.net;
build-dev;
Doug
Hi Dan,
Looks good to me. (I never run the install targets :( )
Thanks,
David
On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
This code review request is going to three different aliases.
Don't use Thunderbird's "reply to list" option since it will
pick just _one_ of the _three_ lists.
Gree
On 2/5/14 9:28 PM, David Holmes wrote:
Hi Dan,
Looks good to me.
Thanks for the review!
(I never run the install targets :( )
Neither do I and apparently neither does JPRT... That's how this
slipped through the cracks...
Dan
Thanks,
David
On 6/02/2014 9:20 AM, Daniel D. Daugherty wr
Looks good to me too. Thanks for fixing this.
tom
On Feb 6, 2014, at 6:07 AM, Daniel D. Daugherty
wrote:
> On 2/5/14 9:28 PM, David Holmes wrote:
>> Hi Dan,
>>
>> Looks good to me.
>
> Thanks for the review!
>
>
>> (I never run the install targets :( )
>
> Neither do I and apparently nei
On 2/6/14 9:29 AM, Doug Simon wrote:
Not sure if I’m being asked for a review, but if so, looks good.
Yes, I was looking for a review. In particular because I tweaked your
original fix...
Thanks for the review!
Dan
On Feb 6, 2014, at 5:07 PM, Tom Rodriguez wrote:
Looks good to me too.
Not sure if I’m being asked for a review, but if so, looks good.
On Feb 6, 2014, at 5:07 PM, Tom Rodriguez wrote:
> Looks good to me too. Thanks for fixing this.
>
> tom
>
> On Feb 6, 2014, at 6:07 AM, Daniel D. Daugherty
> wrote:
>
>> On 2/5/14 9:28 PM, David Holmes wrote:
>>> Hi Dan,
>>>
On 02/ 6/14 08:32 AM, Daniel D. Daugherty wrote:
Looks good to me, Dan
Tim
On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
This code review request is going to three different aliases.
Don't use Thunderbird's "reply to list" option since it will
pick just _one_ of the _three_ lists.
Greeti
Thanks for the review!
Dan
On 2/6/14 9:53 AM, Tim Bell wrote:
On 02/ 6/14 08:32 AM, Daniel D. Daugherty wrote:
Looks good to me, Dan
Tim
On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
This code review request is going to three different aliases.
Don't use Thunderbird's "reply to list" o
