Hi Igor,
It looks good.
Thanks,
Serguei
On 5/1/18 19:10, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
41276 lines changed: 41274 ins; 1 del; 1 mod;
Hi all,
could you please review the patch which open sources monitoring tests from vm
testbase?
On 5/2/18 11:57 AM, Igor Ignatyev wrote:
Vladimir,
we can introduce 'quick' keyword, mark these tests w/ them and use this keyword
in test selection. I personally don't like this way either, as it uses a
loosely defined property. it also might be possible to create a separate test
group file
Vladimir,
we can introduce 'quick' keyword, mark these tests w/ them and use this keyword
in test selection. I personally don't like this way either, as it uses a
loosely defined property. it also might be possible to create a separate test
group file and use it to define only _quick groups. I'
I wish we have ability to include other files with definitions into
TEST.group file. It is very ugly to double size of TEST.group file just
for that purpose.
Thanks,
Vladimir
On 5/1/18 9:39 PM, Igor Ignatev wrote:
Vladimir,
Tests are listed only in _quick test group b/c it doesn’t include al
Build changes look fine.
/Magnus
> 2 maj 2018 kl. 04:10 skrev Igor Ignatyev :
>
> http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
>> 41276 lines changed: 41274 ins; 1 del; 1 mod;
>
> Hi all,
>
> could you please review the patch which open sources monitoring tests from vm
Vladimir,
Tests are listed only in _quick test group b/c it doesn’t include all tests
from the directory. We use this group in some of our test configurations, and
:vmTestbase_nsk_monitoring in others. vmTestbase_nsk_monitoring is defined by
the directory as other groups.
Thanks,
— Igor
> On
Igor,
Why you need to list each test in TEST.groups and not just directory as
we do in other cases?
Thanks,
Vladimir
On 5/1/18 7:10 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
41276 lines changed: 41274 ins; 1 del; 1 mod;
Hi all,
could you
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
> 41276 lines changed: 41274 ins; 1 del; 1 mod;
Hi all,
could you please review the patch which open sources monitoring tests from vm
testbase?
The tests were developed to test hotspot related JMX functionality. as w/
common
