David, Christian, Magnus,
Thank you for review.
Misha
On 04/03/2018 05:15 AM, Magnus Ihse Bursie wrote:
On 2018-03-31 09:30, David Holmes wrote:
Hi Misha.
This all seems okay.
On 30/03/2018 12:41 PM, Mikhailo Seledtsov wrote:
While testing I discovered build errors on Mac and Solaris. The
On 2018-03-31 09:30, David Holmes wrote:
Hi Misha.
This all seems okay.
On 30/03/2018 12:41 PM, Mikhailo Seledtsov wrote:
While testing I discovered build errors on Mac and Solaris. The
following statement " BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest
:= -ljvm" was added to a Linux-only b
Hi Misha,
This looks good, thanks for doing this.
Thanks,
Christia
> On Mar 29, 2018, at 10:41 04PM, Mikhailo Seledtsov
> wrote:
>
> While testing I discovered build errors on Mac and Solaris. The following
> statement " BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest := -ljvm" was
> added
Hi Misha.
This all seems okay.
On 30/03/2018 12:41 PM, Mikhailo Seledtsov wrote:
While testing I discovered build errors on Mac and Solaris. The
following statement " BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest :=
-ljvm" was added to a Linux-only block. I have updated the make file to
add
While testing I discovered build errors on Mac and Solaris. The
following statement " BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest :=
-ljvm" was added to a Linux-only block. I have updated the make file to
add this for any platform w/o conditions; the " exesigtest.c" is
excluded from Windows
I have addressed feedback from Christian, David and Magnus. Here is the
updated webrev:
http://cr.openjdk.java.net/~mseledtsov/8200126.01.open/index.html
I have also confirmed that output from exesigtest.c printf() is logged
into .jtr files.
Grepped for "signal", I can see the output
Magnus,
Thank you for advice. I have updated the makefile accordingly. Will post
updated webrev shortly.
Misha
On 03/28/2018 03:26 PM, Magnus Ihse Bursie wrote:
Yes, you seem to have based this off an old version of
JtregNativeHotspot.gmk.
If you update the file I think you see how you s
On 2018-03-29 00:15, mikhailo wrote:
Hi David,
Thank you for reviewing the change. Please see my comments inline.
On 03/27/2018 07:23 PM, David Holmes wrote:
Hi Misha,
For the benefit of the broader community these are very old tests
related to the use of ligjsig, that were recently con
Hi David,
Thank you for reviewing the change. Please see my comments inline.
On 03/27/2018 07:23 PM, David Holmes wrote:
Hi Misha,
For the benefit of the broader community these are very old tests
related to the use of ligjsig, that were recently converted to be
jtreg tests in preparation
