Re: RFR(S): JDK-8077137 Port jdk.internal.instrumentation to jdk 9

2015-04-09 Thread Magnus Ihse Bursie
On 2015-04-08 12:21, Staffan Larsen wrote: Please review these small changes to support an addition of closed code to the java.instrument module. webrev: http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/ http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/ Looks good to me.

Re: RFR(S): JDK-8077137 Port jdk.internal.instrumentation to jdk 9

2015-04-08 Thread Erik Joelsson
Looks good to me. /Erik On 2015-04-08 12:21, Staffan Larsen wrote: Please review these small changes to support an addition of closed code to the java.instrument module. webrev: http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/ http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/

RFR(S): JDK-8077137 Port jdk.internal.instrumentation to jdk 9

2015-04-08 Thread Staffan Larsen
Please review these small changes to support an addition of closed code to the java.instrument module. webrev: http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/ http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/ Thanks, /Staffan

Re: RFR(S): JDK-8077137 Port jdk.internal.instrumentation to jdk 9

2015-04-08 Thread Mandy Chung
On 4/8/2015 3:21 AM, Staffan Larsen wrote: Please review these small changes to support an addition of closed code to the java.instrument module. webrev: http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/ http://cr.openjdk.java.net/~sla/8077137-open/webrev.01/ The change looks fine.