Vladimir/Magnus/Erik,
Thanks for the reviews, change pushed.
Cheers,
Mikael
> On Apr 29, 2020, at 5:45 AM, Erik Joelsson wrote:
>
> Looks good.
>
> /Erik
>
> On 2020-04-28 21:12, Mikael Vidstedt wrote:
>> Please review this small change which disables JVMCI, Graal, and AOT when
>>
> On Apr 29, 2020, at 3:44 AM, Andrew Haley wrote:
>
> On 4/29/20 10:02 AM, Mikael Vidstedt wrote:
>>
>>> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote:
>>>
>>> On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
Please review this small change which disables JVMCI, Graal, and AOT when
Looks good.
/Erik
On 2020-04-28 21:12, Mikael Vidstedt wrote:
Please review this small change which disables JVMCI, Graal, and AOT when
building linux-aarch64 at Oracle, for now.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
webrev:
On 4/29/20 10:02 AM, Mikael Vidstedt wrote:
>
>> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote:
>>
>> On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
>>> Please review this small change which disables JVMCI, Graal, and AOT when
>>> building linux-aarch64 at Oracle, for now.
>>>
>>> JBS:
Ok, thanks for the clarification. I wasn’t sure if external parties had managed
to set up a jib server but it sounds like that’s not so easy in practice.
-Doug
> On 29 Apr 2020, at 11:02, Magnus Ihse Bursie
> wrote:
>
> On 2020-04-29 10:45, Doug Simon wrote:
>> If I understand correctly,
> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote:
>
> On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
>> Please review this small change which disables JVMCI, Graal, and AOT when
>> building linux-aarch64 at Oracle, for now.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
>> webrev:
On 2020-04-29 10:45, Doug Simon wrote:
If I understand correctly, this disables building jvmci/graal/aot in *any*
linux-aarch64 jib based build, not just those done at Oracle. Wouldn’t this be
better done on the jib command line?
While this is technically correct, the jib tool is only used at
JIB is an Oracle (internal) tool, meaning the jib-profiles.js configuration
file is only relevant at Oracle, so this really only affects builds done at
Oracle. Does that address your concern?
Cheers,
Mikael
> On Apr 29, 2020, at 1:45 AM, Doug Simon wrote:
>
> If I understand correctly,
If I understand correctly, this disables building jvmci/graal/aot in *any*
linux-aarch64 jib based build, not just those done at Oracle. Wouldn’t this be
better done on the jib command line?
-Doug
> On 29 Apr 2020, at 06:12, Mikael Vidstedt wrote:
>
>
> Please review this small change which
On 2020-04-29 06:12, Mikael Vidstedt wrote:
Please review this small change which disables JVMCI, Graal, and AOT when
building linux-aarch64 at Oracle, for now.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
webrev:
On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
> Please review this small change which disables JVMCI, Graal, and AOT when
> building linux-aarch64 at Oracle, for now.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
> webrev:
>
Good.
Thanks,
Vladimir
On 4/28/20 9:12 PM, Mikael Vidstedt wrote:
Please review this small change which disables JVMCI, Graal, and AOT when
building linux-aarch64 at Oracle, for now.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
webrev:
Please review this small change which disables JVMCI, Graal, and AOT when
building linux-aarch64 at Oracle, for now.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244061/webrev.00/open/webrev/
Cheers,
Mikael
13 matches
Mail list logo
