On Sun, 22 May 2022 08:35:54 GMT, Yasumasa Suenaga wrote:
>> `Array::_data` is a pseudo flexible array member. "Pseudo" because C++
>> doesn't have flexible array members. The compiler is completely justified in
>> complaining about the apparently out-of-bounds accesses.
>>
>> There is a "well-k
On Sun, 22 May 2022 05:00:21 GMT, Kim Barrett wrote:
>> I guess GCC cannot understand `assert(dest != NULL` immediately preceding it.
>>
>>
>> In file included from
>> /home/ysuenaga/github-forked/jdk/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.inline.hpp:33,
On Sun, 22 May 2022 03:15:20 GMT, Kim Barrett wrote:
>> Like the others, it is caused by `Array::at_put()`.
>>
>>
>> In file included from
>> /home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/annotations.hpp:28,
>> from
>> /home/ysuenaga/github-forked/jdk/src/hotspot/sh
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Tue, 17 May 2022 12:43:02 GMT, Yasumasa Suenaga wrote:
>> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp
>> line 103:
>>
>>> 101: PRAGMA_STRINGOP_OVERFLOW_IGNORED
>>> 102: *dest = op(bits, *dest);
>>> 103: PRAGMA_DIAG_POP
>>
>> I see no stringop here. I
On Tue, 17 May 2022 12:38:55 GMT, Yasumasa Suenaga wrote:
>> src/hotspot/share/classfile/classFileParser.cpp line 5970:
>>
>>> 5968: PRAGMA_STRINGOP_OVERFLOW_IGNORED
>>> 5969: _cp->symbol_at_put(hidden_index, _class_name);
>>> 5970: PRAGMA_DIAG_POP
>>
>> I don't understand these warning suppr
On Tue, 17 May 2022 13:32:42 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Fri, 20 May 2022 09:37:03 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On Sat, 2 Apr 2022 05:54:16 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 58 commits:
>>
>> - Apply remaining review comments from Thomas Stuefe
>> - Change load_dwarf_file with
On Fri, 8 Apr 2022 11:11:29 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x
> When printing the native stack trace on Linux (mostly done for hs_err files),
> it only prints the method with its parameters and a relative offset in the
> method:
>
> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e01838110, free
> space=1020k
> Native frames: (J=compiled Jav
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Build changes look good. Thanks for the cleanu
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Tue, 17 May 2022 06:30:03 GMT, David Holmes wrote:
> Sorry Kim I'm having trouble seeing what change corresponds to (1) ??
The change to CompileJvm.gmk, removing 4996 (deprecation warnings)
from the list of disabled warnings.
> Also the PR talks only about hotspot, but you're changing the JD
On Thu, 19 May 2022 14:36:28 GMT, Andrew Haley wrote:
> > Some concerns:
> > ```
> > 1. It should work at least for Clang and GCC but still will require
> > checking all os-cpu/compiler variants.
Non-Linux systems don't use this stuff at all, so don't worry about it.
-
PR: https:/
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Thu, 19 May 2022 10:05:41 GMT, Dmitry Chuyko wrote:
> Some concerns:
>
> 1. It should work at least for Clang and GCC but still will require
> checking all os-cpu/compiler variants.
Really, no. Don't think that way. Just do Linux for now, and throw it over the
wall for Windows people.
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Thu, 19 May 2022 08:43:55 GMT, Nick Gasson wrote:
> What's the advantage of defining the new hardlse VM feature over using the
> existing `__ARM_FEATURE_ATOMICS` preprocessor symbol? Both GCC and Clang will
> define that with an appropriate `-march` value, which you're passing to
> configur
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Thu, 19 May 2022 07:59:56 GMT, Andrew Haley wrote:
> This looks reasonable enough, but I take it that this would create an OpenJDK
> build that would not run on AArch64 systems without LSE instructions.
Forget that, we already do so with extra-cflags.
-
PR: https://git.openjdk.
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
javac and javadoc changes look OK
test/langto
On AArch64 it is sometimes convenient to have LSE atomics right from the start.
Currently they are enabled after feature detection and RR reverse debugger
works incorrectly.
New build configuration feature 'hardlse' is added. If it is enabled for
aarch64 type of build, then statically compiled
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by iris (Reviewer).
--
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Logging/JNDI OK
-
Marked as revi
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Looked at
-java.security.jgss.
LGTM
--
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by lancea (Reviewer).
Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
It's the last issue in the series, and it still touches different areas of the
code.
-
Commit messages:
- 8284209: Replace remaining usages of 'the a' in source code
- 8284209: Replac
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will enf
On Tue, 17 May 2022 04:52:44 GMT, Kim Barrett wrote:
>> src/hotspot/share/opto/memnode.cpp line 1413:
>>
>>> 1411:bt == T_BYTE|| bt == T_SHORT ||
>>> 1412:bt == T_INT || bt == T_LONG, "wrong type =
>>> %s", type2name(bt));
>>> 1413: PRAGMA_DIAG_PO
On Tue, 17 May 2022 03:06:49 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/opto/type.cpp line 4300:
>
>> 42
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Tue, 17 May 2022 03:14:05 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/classfile/bytecodeAssembler.cpp l
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Tue, 17 May 2022 03:02:55 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/jfr/recorder/checkpoint/types/tra
On Tue, 17 May 2022 01:43:25 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/classfile/classFileParser.cpp lin
On Sun, 15 May 2022 20:50:25 GMT, Kim Barrett wrote:
> Please review this cleanup of deprecation warning suppression when building
> for Windows.
>
> This change consists of several parts.
>
> (1) Remove the global deprecation warning suppression when building HotSpot
> for Windows.
>
> (2) Ad
On Tue, 17 May 2022 03:05:09 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/opto/memnode.cpp line 1413:
>
>>
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Thu, 12 May 2022 18:28:02 GMT, Kim Barrett wrote:
>> Thanks for all to review this PR! I think we should separate this issue as
>> following:
>>
>> * Suppress warnings
>> * make/modules/java.desktop/lib/Awt2dLibraries.gmk
>> * src/hotspot/share/classfile/bytecodeAssembler.cpp
>>
On Thu, 12 May 2022 11:02:02 GMT, Magnus Ihse Bursie wrote:
>> Thanks for all to review this PR! I think we should separate this issue as
>> following:
>>
>> * Suppress warnings
>> * make/modules/java.desktop/lib/Awt2dLibraries.gmk
>> * src/hotspot/share/classfile/bytecodeAssembler.cpp
On Mon, 16 May 2022 22:06:25 GMT, Leonid Mesnik wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year
>
> Looks reasonable.
Thank you @lmesnik for the review.
-
PR: https://git.openjdk.java
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as s
On Thu, 12 May 2022 00:26:41 GMT, Yasumasa Suenaga wrote:
>> I don't understand what the actual warning is getting at .. can anyone
>> explain it ?
>>
>> FWIW the code is still the same in upstream harfbuzz
>> https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-font.cc
>
> I've pasted a part
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Sun, 15 May 2022 20:50:25 GMT, Kim Barrett wrote:
> Please review this cleanup of deprecation warning suppression when building
> for Windows.
>
> This change consists of several parts.
>
> (1) Remove the global deprecation warning suppression when building HotSpot
> for Windows.
>
> (2) Ad
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
On Mon, 16 May 2022 11:37:43 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to
>> address artefact tagging for Compiler threads, letting threads run
>> _thread_in_native to avoid the transition. Unfortunately, that atte
> Greetings,
>
> [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to
> address artefact tagging for Compiler threads, letting threads run
> _thread_in_native to avoid the transition. Unfortunately, that attempt proved
> inadequate.
>
> The epoch race is avoided only by
On Mon, 16 May 2022 10:17:42 GMT, Markus Grönlund wrote:
> Greetings,
>
> [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to
> address artefact tagging for Compiler threads, letting threads run
> _thread_in_native to avoid the transition. Unfortunately, that attempt p
On Mon, 16 May 2022 07:54:09 GMT, Jaikiran Pai wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year
>
> Thank you Daniel and Lance for the reviews.
>
> Would anyone from the build team like to provide a
Greetings,
[JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to
address artefact tagging for Compiler threads, letting threads run
_thread_in_native to avoid the transition. Unfortunately, that attempt proved
inadequate.
The epoch race is avoided only by performing the
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as s
On Fri, 13 May 2022 10:04:25 GMT, Magnus Ihse Bursie wrote:
>> I'm back to work again. I also had a look but could not find something on
>> Google, either. I then skimmed through the old GCC manuals. I found the
>> first occurrence of `-gdwarf-4` in the manual for GCC 4.5.4
>> [here](https://g
Please review this cleanup of deprecation warning suppression when building
for Windows.
This change consists of several parts.
(1) Remove the global deprecation warning suppression when building HotSpot
for Windows.
(2) Add macro definitions requesting suppression of selected sets of
deprecatio
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8706
On Fri, 13 May 2022 22:11:17 GMT, Joe Wang wrote:
>> Applied required casts for the upcoming warning. Verified by cherry-picking
>> Adam's patch.
>
> make/jdk/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java
> line 1278:
>
>> 1276: state[numCateg
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
make/jdk/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java
line 1278:
> 1276: state[numCategories] |
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as s
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8706
Applied required casts for the upcoming warning. Verified by cherry-picking
Adam's patch.
-
Commit messages:
- 8286399: Address possibly lossy conversions in JDK Build Tools
Changes: https://git.openjdk.java.net/jdk/pull/8706/files
Webrev: https://webrevs.openjdk.java.net/?repo=jd
On Fri, 13 May 2022 14:36:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as s
> Can I please get a review of this change which proposes to fix the failure
> handler command `dmesg` on macOS?
>
> As noted in the JBS issue, the command currently fails with permission error.
> The commit in this PR uses `sudo` as suggested in the man pages of that
> command.
>
> Tested loc
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Fri, 13 May 2022 09:42:44 GMT, Maurizio Cimadamore
wrote:
>> This change here also closes
>> [JDK-8259034](https://bugs.openjdk.java.net/browse/JDK-8259034)
>
> @uschindler - the issue you mention with respect lack of UOE for wrong file
> system applies to BB as well. I suggest filing an is
On Fri, 13 May 2022 11:59:12 GMT, Maurizio Cimadamore
wrote:
>> RFE = issue?
>
>> RFE = issue?
>
> issue, with type RFE (request for enhancement)
See: https://bugs.openjdk.java.net/browse/JDK-8286734
-
PR: https://git.openjdk.java.net/jdk/pull/7888
On Fri, 13 May 2022 11:01:09 GMT, Uwe Schindler wrote:
> RFE = issue?
issue, with type RFE (request for enhancement)
-
PR: https://git.openjdk.java.net/jdk/pull/7888
On Fri, 13 May 2022 09:43:55 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 1164:
>>
>>> 1162: }
>>> 1163: if (unmapper != null) {
>>> 1164: AbstractMemorySegmentImpl segment = new
>>> MappedMemorySegmentImpl(unma
On Fri, 13 May 2022 08:43:35 GMT, Christian Hagedorn
wrote:
>> I'm googling around for some information about -gdwarf-4 but is mostly
>> coming up empty handed. :( I found
>> [this](https://www.phoronix.com/scan.php?page=news_item&px=GCC-11-DWARF-5-Possible-Default)
>> saying that dwarf-5 bec
On Fri, 8 Apr 2022 11:11:29 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Fri, 13 May 2022 08:29:13 GMT, Uwe Schindler wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 65 commits:
>>
>> - Merge branch 'master' into foreign-preview
>> - Merge branch 'master' into foreign
On Fri, 13 May 2022 08:33:11 GMT, Uwe Schindler wrote:
>> src/java.base/share/classes/java/nio/channels/FileChannel.java line 1045:
>>
>>> 1043: *
>>> 1044: * @throws UnsupportedOperationException
>>> 1045: * If an unsupported map mode is specified.
>>
>> I think this sho
On Fri, 8 Apr 2022 11:11:29 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x
On Fri, 8 Apr 2022 13:34:03 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/flags-cflags.m4 line 116:
>>
>>> 114: fi
>>> 115:
>>> 116: CFLAGS_DEBUG_SYMBOLS="-g -gdwarf-4"
>>
>> We may need to guard this with a FLAGS_COMPILER_CHECK_ARGUMENTS. Perhaps it
>> should also be applied only o
On Fri, 13 May 2022 08:25:01 GMT, Uwe Schindler wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 65 commits:
>>
>> - Merge branch 'master' into foreign-preview
>> - Merge branch 'master' into foreign
On Thu, 12 May 2022 15:45:01 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On Thu, 12 May 2022 20:59:53 GMT, Michael Hall wrote:
> However, I don't know how the app is supposed to be started without a
> launcher...
jpackage supplies an alternative launcher that doesn't have plist.
-
PR: https://git.openjdk.java.net/jdk/pull/8666
> On May 12, 2022, at 3:13 PM, Magnus Ihse Bursie wrote:
>
> On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
> wrote:
>
>>> - It is not possible to support native JDK commands such as "java" inside
>>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>>> JDK-
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will enf
On Thu, 12 May 2022 01:27:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
> What you say sounds good, although I feel I only partially understand it. :-)
If it’s correct that normal applications don’t need the executable included
Info.plist and jpackage can somehow get versions that don’t include it that
seems the easiest and most hack free solution.
Apple DTS did s
>
> What you say sounds good, although I feel I only partially understand it. :-)
If it’s correct that normal applications don’t need the executable included
Info.plist and jpackage can somehow get versions that don’t include it that
seems the easiest and most hack free solution.
Apple DTS d
On Thu, 12 May 2022 01:29:13 GMT, Yasumasa Suenaga wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Calculate char offset before realloc()
>
> Thanks for all to review this PR! I think we should separate this is
Aren't we embedding this bundle ID in every launcher, so you would
need a .template for each possible launcher that could be
included in an app?
I naively assumed that only the java launcher was needed, since this is
about packaging a Java app, so all you'd need is an entry to your main
clas
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will enf
On Fri, 29 Apr 2022 08:29:52 GMT, Guoxiong Li wrote:
>>> Remind: please use the command `/jep JEP-424` [1] to mark this PR.
>>>
>>> [1]
>>> https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep
>>
>> Question: I'm willing to try it out. If something goes wr
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
> On May 12, 2022, at 8:10 AM, Michael Hall wrote:
>
>
>
>>
>> My primary suggestion would to be to use an UUID for the unique ID. They are
>> of fixed length, are for all intents and purposes unique and you can conjure
>> them up from your hat. (An alternative is that the user needs to
On 2022-05-12 04:58, Magnus Ihse Bursie wrote:
On 2022-05-12 13:17, Michael Hall wrote:
A solution like including a bundle identifier something like
net.java.openjdk.MYAPP.java would be possible at packaging time but
not at build time.
To fix this at build time you would need to generate a na
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
>
> My primary suggestion would to be to use an UUID for the unique ID. They are
> of fixed length, are for all intents and purposes unique and you can conjure
> them up from your hat. (An alternative is that the user needs to specify a
> unique ID, but that is probably a less ideal solution
On Wed, 11 May 2022 20:55:29 GMT, Adam Farley wrote:
> These warnings are ignored while building the build+full jdks with gcc,
> but only ignored while building the full JDK if using clang. This
> produces tons of warnings we normally ignore, e.g. unused parameter.
>
> I suggest that if we're ig
201 - 300 of 5319 matches
Mail list logo
