Re: RFR: [8u] 8141570: Fix Zero interpreter build for --disable-precompiled-headers

2019-08-22 Thread Severin Gehwolf
On Thu, 2019-08-22 at 10:15 +0100, Andrew Hughes wrote: > Here it is: https://cr.openjdk.java.net/~andrew/openjdk8/8141570/ Looks good. Thanks, Severin

Re: RFR: [8u] 8141570: Fix Zero interpreter build for --disable-precompiled-headers

2019-08-22 Thread Andrew Hughes
On Thu, 22 Aug 2019 at 09:52, Severin Gehwolf wrote: > > Hi Andrew, > > On Wed, 2019-08-21 at 20:33 +0100, Andrew John Hughes wrote: > > This is the first of a series of four changes to support -Wreturn-type > > in OpenJDK 8u. The -Wreturn-type warning catches instances where control > > flow exit

Re: RFR: [8u] 8141570: Fix Zero interpreter build for --disable-precompiled-headers

2019-08-22 Thread Severin Gehwolf
Hi Andrew, On Wed, 2019-08-21 at 20:33 +0100, Andrew John Hughes wrote: > This is the first of a series of four changes to support -Wreturn-type > in OpenJDK 8u. The -Wreturn-type warning catches instances where control > flow exits a non-void function without returning a value. This can > combine

RFR: [8u] 8141570: Fix Zero interpreter build for --disable-precompiled-headers

2019-08-21 Thread Andrew John Hughes
This is the first of a series of four changes to support -Wreturn-type in OpenJDK 8u. The -Wreturn-type warning catches instances where control flow exits a non-void function without returning a value. This can combine with compiler optimisations in some cases to cause runtime crashes. The warning