Hi Mike:
That's quite a makeover. Looks good to me.
Tim
Reminder:
http://cr.openjdk.java.net/~mduigou/JDK-8026062/2
needs final review.
Mike
On Oct 14 2013, at 11:56 , Mike Duigou wrote:
On Oct 11 2013, at 18:03 , Weijun Wang wrote:
The webrev shows """ inside the "Bug id" header ent
Looks fine.
Thanks
Max
On 10/17/13 6:31 AM, Mike Duigou wrote:
Reminder:
http://cr.openjdk.java.net/~mduigou/JDK-8026062/2
needs final review.
Mike
On Oct 14 2013, at 11:56 , Mike Duigou wrote:
On Oct 11 2013, at 18:03 , Weijun Wang wrote:
The webrev shows """ inside the "Bug id" head
Looks fine; thanks for giving webrev some love!
-Joe
On 10/16/2013 3:31 PM, Mike Duigou wrote:
Reminder:
http://cr.openjdk.java.net/~mduigou/JDK-8026062/2
needs final review.
Mike
On Oct 14 2013, at 11:56 , Mike Duigou wrote:
On Oct 11 2013, at 18:03 , Weijun Wang wrote:
The webrev sho
Mike,
Looks good for me
(not a reviewer)
-Dmitry
On 2013-10-17 02:31, Mike Duigou wrote:
> Reminder:
>
> http://cr.openjdk.java.net/~mduigou/JDK-8026062/2
>
> needs final review.
>
> Mike
>
> On Oct 14 2013, at 11:56 , Mike Duigou wrote:
>
>>
>> On Oct 11 2013, at 18:03 , Weijun Wang w
Reminder:
http://cr.openjdk.java.net/~mduigou/JDK-8026062/2
needs final review.
Mike
On Oct 14 2013, at 11:56 , Mike Duigou wrote:
>
> On Oct 11 2013, at 18:03 , Weijun Wang wrote:
>
>> The webrev shows """ inside the "Bug id" header entry.
>
> I have fixed this. It was being double escap
On Oct 11 2013, at 18:03 , Weijun Wang wrote:
> The webrev shows """ inside the "Bug id" header entry.
I have fixed this. It was being double escaped. ie. "
Updated webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8026062/2
>
> Also, the following headers look a little suspicious:
>
>
The webrev shows """ inside the "Bug id" header entry.
Also, the following headers look a little suspicious:
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate
Compare against version: -2
I usually compare with -2 when -1 is an mq patch and I also have "-N".
But the "compare against
On Oct 11 2013, at 14:56 , Bradford Wetmore wrote:
> It never worked like it did in Teamware.
Thanks Brad, that's what I thought reading the source. It appeared that it had
never been implemented for mercurial. I have removed support for -l
Here's an updated webrev (generated with itself!):
h
It never worked like it did in Teamware.
Brad
On 10/11/2013 11:33 AM, Mike Duigou wrote:
I should also ask if anyone is using the -l option. I would like to delete it
as well as it offers no particular value for mercurial (that I can tell).
Mike
On Oct 10 2013, at 17:20 , Weijun Wang wrote:
I should also ask if anyone is using the -l option. I would like to delete it
as well as it offers no particular value for mercurial (that I can tell).
Mike
On Oct 10 2013, at 17:20 , Weijun Wang wrote:
>
>
> On 10/10/13 1:13 PM, Mike Duigou wrote:
>>
>> On Oct 9 2013, at 22:11 , Weijun Wang
Yes, both works. Thanks.
--Max
On 10/11/13 2:56 PM, Vadim Pakhnushev wrote:
You probably either supply a list file as a parameter, or pipe with '-'
as a parameter.
At least file name as a parameter works for me, haven't tried '-' with
pipe.
Thanks,
Vadim
On 11.10.2013 4:20, Weijun Wang wrote:
You probably either supply a list file as a parameter, or pipe with '-'
as a parameter.
At least file name as a parameter works for me, haven't tried '-' with pipe.
Thanks,
Vadim
On 11.10.2013 4:20, Weijun Wang wrote:
On 10/10/13 1:13 PM, Mike Duigou wrote:
On Oct 9 2013, at 22:11 , Weijun
On 10/10/13 1:13 PM, Mike Duigou wrote:
On Oct 9 2013, at 22:11 , Weijun Wang wrote:
Some of us still use wxfile to generate a single webrev for code changes in
multiple repos. Is there another way to do it?
Yes, you can pipe a simple file list to webrev to have it use that list of
files
On Oct 9 2013, at 19:45 , John Rose wrote:
> On Oct 9, 2013, at 3:54 PM, Mike Duigou wrote:
>
>> Hello all;
>>
>> This changeset revisits webrev's integration with bugs.openjdk.java.net to
>> correct problems with the scraping of bug titles from jbs html. I also
>> eliminated the now obsolet
On Oct 9 2013, at 22:11 , Weijun Wang wrote:
> Some of us still use wxfile to generate a single webrev for code changes in
> multiple repos. Is there another way to do it?
Yes, you can pipe a simple file list to webrev to have it use that list of
files. I removed wxfile support in part because
Some of us still use wxfile to generate a single webrev for code changes
in multiple repos. Is there another way to do it?
Thanks
Max
On 10/10/13 6:54 AM, Mike Duigou wrote:
Hello all;
This changeset revisits webrev's integration with bugs.openjdk.java.net to correct
problems with the scrapi
On Oct 9, 2013, at 3:54 PM, Mike Duigou wrote:
> Hello all;
>
> This changeset revisits webrev's integration with bugs.openjdk.java.net to
> correct problems with the scraping of bug titles from jbs html. I also
> eliminated the now obsolete "-O" option since bugs are now all visible on the
>
On 10/09/2013 03:54 PM, Mike Duigou wrote:
Hello all;
This changeset revisits webrev's integration with bugs.openjdk.java.net to correct
problems with the scraping of bug titles from jbs html. I also eliminated the now
obsolete "-O" option since bugs are now all visible on the preferred
bugs.
Hello all;
This changeset revisits webrev's integration with bugs.openjdk.java.net to
correct problems with the scraping of bug titles from jbs html. I also
eliminated the now obsolete "-O" option since bugs are now all visible on the
preferred bugs.openjdk.java.net system.
While I was at it
19 matches
Mail list logo
