That may be just webrev. I did do an hg mv.
But until you 'hg commit' the move, mercurial will claim no knowledge of
the file :-
$ hg log src/java.desktop/unix/native/libawt/sun/awt/initIDs.c
abort: cannot follow file not in parent revision:
"src/java.desktop/unix/native/libawt/sun/awt/initIDs
On 2014-09-10 23:10, Phil Race wrote:
Updated webrev :- http://cr.openjdk.java.net/~prr/8056213.1/
Looks good. However, the webrev shows the file as being moved outside
the control of mercurial. That is, if you do "hg mv" to move the file,
the history of the file will be kept intact. Otherwis
This looks good to me.
/Erik
On 2014-09-10 23:10, Phil Race wrote:
Updated webrev :- http://cr.openjdk.java.net/~prr/8056213.1/
-phil.
On 09/10/2014 01:28 PM, Phil Race wrote:
I now see InitIDs.m defines more stubs than initIDs.c since
1) some stubs for xawt are instead defined in XToolkit.
Updated webrev :- http://cr.openjdk.java.net/~prr/8056213.1/
-phil.
On 09/10/2014 01:28 PM, Phil Race wrote:
I now see InitIDs.m defines more stubs than initIDs.c since
1) some stubs for xawt are instead defined in XToolkit.c
2) some xawt cases (eg Button) have more than an empty stub - actual
I now see InitIDs.m defines more stubs than initIDs.c since
1) some stubs for xawt are instead defined in XToolkit.c
2) some xawt cases (eg Button) have more than an empty stub - actual
content.
3) Some aren't defined at all in the case you have headless awt but
they can't be reached because of
> That means that instead of having to add even more excludes, you can
delete some existing
Doing that leaves just this one :-
ifeq ($(OPENJDK_TARGET_OS), macosx)
LIBAWT_EXFILES += initIDs.c sun/awt/image/cvutils/img_colors.c
endif
So its actually excluded from the core libawt on OS X.
It s
On 2014-09-09 23:17, Phil Race wrote:
After looking at the issues in the bug report below I think the only
think that must be fixed is the unnecessary inclusion of initIDS.c in
libawt_xawt.so
You are correct indeed. I had missed the fact that awt_Font.c,
fontpath.c and X11Color.c was included
After looking at the issues in the bug report below I think the only
think that must be fixed is the unnecessary inclusion of initIDS.c in
libawt_xawt.so
https://bugs.openjdk.java.net/browse/JDK-8056213
http://cr.openjdk.java.net/~prr/8056213/
I've tested this out on Linux and am submitting a
