Re: RFR: 8065648: Remove the flag -fsanitize=undefined for GCC 4.9 and later

2014-11-24 Thread Erik Joelsson
Right, it's not a question of our code hitting the check, it's the compiler crashing on us. We can't have errors in the compiler we use. Looks good to me. Don't forget to regenerate configure and also push the closed version. /Erik On 2014-11-24 15:07, Erik Helin wrote: Hi Erik, thanks for

Re: RFR: 8065648: Remove the flag -fsanitize=undefined for GCC 4.9 and later

2014-11-24 Thread Erik Helin
Hi Erik, thanks for having a look! I realized that I had forgot to remove one usage of $HAS_CFLAG_DETECT_UNDEFINED_BEHAVIOR, please see new webrev at: http://cr.openjdk.java.net/~ehelin/8065648/webrev.01/ On 2014-11-24, Erik Joelsson wrote: > I think it's a reasonable change to remove the flag a

Re: RFR: 8065648: Remove the flag -fsanitize=undefined for GCC 4.9 and later

2014-11-24 Thread Erik Joelsson
I think it's a reasonable change to remove the flag as it has most likely not seen much use (if any) yet. I'm not sure what it does, but I assume it's something to improve exploit protection the source code. But if it doesn't work, we can't use it. We could also consider disabling the flag for

RFR: 8065648: Remove the flag -fsanitize=undefined for GCC 4.9 and later

2014-11-21 Thread Erik Helin
Hi all, this patch removes the usage of the flag -fsanitize=undefined introduced in GCC 4.9. The reason for not using this flag is that the implementation in GCC still seem to have some bugs [0] (which I have encountered). The flag is currently only enabled for slowdebug builds. My suggestion is