Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread serguei.spit...@oracle.com
On 4/23/15 2:50 PM, Erik Joelsson wrote: No, that file is old legacy and not used anymore. It will hopefully soon go away. Ok then. Thanks, Erik! Serguei /Erik On 2015-04-23 12:52, serguei.spit...@oracle.com wrote: It looks good. A question: Do we want to get rid of the jhat in the jdk

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Erik Joelsson
No, that file is old legacy and not used anymore. It will hopefully soon go away. /Erik On 2015-04-23 12:52, serguei.spit...@oracle.com wrote: It looks good. A question: Do we want to get rid of the jhat in the jdk/closed/old-build/common/Release.gmk ? jhat.1 \ com/sun/

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread serguei.spit...@oracle.com
It looks good. A question: Do we want to get rid of the jhat in the jdk/closed/old-build/common/Release.gmk ? jhat.1 \ com/sun/tools/hat \ jhat$(EXE_SUFFIX) Thanks, Serguei On 4/23/15 5:06 AM, Staffan Larsen wrote: Please review this change to remove the jhat

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Erik Joelsson
Looks good to me. /Erik On 2015-04-23 05:15, Alan Bateman wrote: On 23/04/2015 13:06, Staffan Larsen wrote: Please review this change to remove the jhat tool. I will not push this change until the tests have been removed (see a different review thread). JEP: https://bugs.openjdk.java.net/

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Alan Bateman
On 23/04/2015 13:06, Staffan Larsen wrote: Please review this change to remove the jhat tool. I will not push this change until the tests have been removed (see a different review thread). JEP: https://bugs.openjdk.java.net/browse/JDK-8059039 bug: https://bugs.openjdk.java.net/browse/JDK-807

RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Staffan Larsen
Please review this change to remove the jhat tool. I will not push this change until the tests have been removed (see a different review thread). JEP: https://bugs.openjdk.java.net/browse/JDK-8059039 bug: https://bugs.openjdk.java.net/browse/JD