Re: RFR: 8087156: SetupNativeCompilation ignores CFLAGS_release for cpp files

2015-06-12 Thread Omair Majid
* Magnus Ihse Bursie [2015-06-12 09:02]: > Looks good to me too. Thanks for the review! Sorry I was unable to credit you since I already pushed the patch. > However, this is not the first time we've encountered a problem like this. I > ran into a similar problem some time ago. It's a very brittl

Re: RFR: 8087156: SetupNativeCompilation ignores CFLAGS_release for cpp files

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-11 08:51, Erik Joelsson wrote: Hello Omair, This looks good to me, thanks for catching it! Looks good to me too. However, this is not the first time we've encountered a problem like this. I ran into a similar problem some time ago. It's a very brittle system we have. I believe we

Re: RFR: 8087156: SetupNativeCompilation ignores CFLAGS_release for cpp files

2015-06-10 Thread Erik Joelsson
Hello Omair, This looks good to me, thanks for catching it! /Erik On 2015-06-11 00:36, Omair Majid wrote: Hi, I discovered a bug in SetupNativeCompilation that results in some C++ code being built with wrong CXXFLAGS. Bug: https://bugs.openjdk.java.net/browse/JDK-8087156 Webrev: http://cr.o

RFR: 8087156: SetupNativeCompilation ignores CFLAGS_release for cpp files

2015-06-10 Thread Omair Majid
Hi, I discovered a bug in SetupNativeCompilation that results in some C++ code being built with wrong CXXFLAGS. Bug: https://bugs.openjdk.java.net/browse/JDK-8087156 Webrev: http://cr.openjdk.java.net/~omajid/webrevs/8087156-setupnativecompilation/00/ It turns out that debugging flags are autom