Re: RFR: 8145471: javac changes for enhanced deprecation

2016-10-20 Thread Jonathan Gibbons
On 10/18/2016 05:00 PM, Jonathan Gibbons wrote: Jan, You're correct, the change in make/CompileJavaModules.gmk is not necessary. Well spotted. The changes to the other make/ file are still necessary for the time being, to suppress warnings until the sources can be updated with appropriate use

Re: RFR: 8145471: javac changes for enhanced deprecation

2016-10-19 Thread Tim Bell
Jon: make/CompileJavaModules.gmk no comments make/common/SetupJavaCompilers.gmk no comments Thumbs up on the build changes. Tim On 10/18/16 17:00, Jonathan Gibbons wrote: Jan, You're correct, the change in make/CompileJavaModules.gmk is not necessary. Well spotted. The cha

Re: RFR: 8145471: javac changes for enhanced deprecation

2016-10-18 Thread Jonathan Gibbons
Jan, You're correct, the change in make/CompileJavaModules.gmk is not necessary. Well spotted. The changes to the other make/ file are still necessary for the time being, to suppress warnings until the sources can be updated with appropriate use of @SuppressWarnings. The use of the literal "

Re: RFR: 8145471: javac changes for enhanced deprecation

2016-10-18 Thread Jan Lahoda
Overall, seem OK to me. Two comments: -is the change in make/CompileJavaModules.gmk really needed given the adjusted JAVAC_WARNINGS in make/common/SetupJavaCompilers.gmk? -the reliance on literal "true" in TypeEnter seems suspicious to me. What if the value of the attribute is a compile-time c

RFR: 8145471: javac changes for enhanced deprecation

2016-10-17 Thread Jonathan Gibbons
Repeat, with subject line. -- Jon On 10/17/2016 03:03 PM, Jonathan Gibbons wrote: Compiler folk, build folk, Please review this update for javac and some build files, for JEP 277. The work supports the enhanced Deprecation attribute, and generates a new warning when items are referenced that