Re: RFR: 8170681 : Remove fontconfig header files from JDK source tree

2017-10-25 Thread Erik Joelsson
Looks good. /Erik On 2017-10-25 17:44, Phil Race wrote: Updated webrev posted as http://cr.openjdk.java.net/~prr/8170681.1 -phil. On 10/25/2017 01:04 AM, Erik Joelsson wrote: Hello, Expanding the help as Sergey suggests is a good idea. The package on Ubuntu is called libfontconfig1-dev an

Re: RFR: 8170681 : Remove fontconfig header files from JDK source tree

2017-10-25 Thread Phil Race
Updated webrev posted as http://cr.openjdk.java.net/~prr/8170681.1 -phil. On 10/25/2017 01:04 AM, Erik Joelsson wrote: Hello, Expanding the help as Sergey suggests is a good idea. The package on Ubuntu is called libfontconfig1-dev and on Redhat fontconfig-devel. In lib-fontconfig.m4, line 7

Re: RFR: 8170681 : Remove fontconfig header files from JDK source tree

2017-10-25 Thread Erik Joelsson
Hello, Expanding the help as Sergey suggests is a good idea. The package on Ubuntu is called libfontconfig1-dev and on Redhat fontconfig-devel. In lib-fontconfig.m4, line 72, no need to look for the same header twice. Otherwise this looks good. /Erik On 2017-10-24 23:15, Philip Race wrote:

Re: [OpenJDK 2D-Dev] RFR: 8170681 : Remove fontconfig header files from JDK source tree

2017-10-24 Thread Sergey Bylokhov
Hi, Phil. Should we update help.m4 as well and add a message for fontconfig like we do for cups and others? cups) PKGHANDLER_COMMAND="sudo apt-get install libcups2-dev" ;; cups) PKGHANDLER_COMMAND="sudo yum install cups-devel" ;; On 24/10/2017 14:15, Philip Race wrote: Bug

RFR: 8170681 : Remove fontconfig header files from JDK source tree

2017-10-24 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8170681 Webrev: http://cr.openjdk.java.net/~prr/8170681/ This fix removes the copy of fontconfig.h from the JDK sources. The file was originally included in the JDK sources because the build platforms of the day were too old to include it. It will h