Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-15 Thread David Holmes
On 12/05/2017 5:16 PM, Magnus Ihse Bursie wrote: Kumar, This was not an improvement. This will require additional changes in the build system to avoid a regression. I see no reason for that. In fact, I propose we close the bug as WNF. Let me elaborate. The problem here is that Oracle has dual

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-12 Thread Jonathan Gibbons
Magnus, I agree with this, and agree with closing it WNF. -- Jon On 05/12/2017 12:16 AM, Magnus Ihse Bursie wrote: Kumar, This was not an improvement. This will require additional changes in the build system to avoid a regression. I see no reason for that. In fact, I propose we close the bu

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-12 Thread Magnus Ihse Bursie
Kumar, This was not an improvement. This will require additional changes in the build system to avoid a regression. I see no reason for that. In fact, I propose we close the bug as WNF. Let me elaborate. The problem here is that Oracle has dual roles: partly as a contributor to OpenJDK, and

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Jonathan Gibbons
Roger, We discussed this in the original design. This is a JDK-specific taglet, for use in the JDK-build, for building JDK API-specifications, that may or may not link to some commercial documentation. There is no intent to support {@extLink} for anything outside its limited use in the JDK

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Roger Riggs
Hi, I would generalize it just a bit by taking the URL from the system property; if the property was set it would use the URL and if not generate the citation. Then the taglet could be used a bit more broadly without complicating the build or code. $.02, Roger On 5/11/2017 4:51 PM, Kumar Sr

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Kumar Srinivasan
Hi, Changes in this webrev: * inverted the logic as you suggested * some doc comment changes to reflect the change http://cr.openjdk.java.net/~ksrini/8179915/webrev.1/ Thanks Kumar On 5/10/2017 7:19 PM, David Holmes wrote: On 11/05/2017 3:18 AM, Kumar Srinivasan wrote: On 5/10/2017 9:51 AM,

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Kumar Srinivasan
Hi Roger, This is a build tool, ie. a tool used by the build system, potentially could be documented in the build notes. Kumar Hi, That's a pretty cryptic property, where will it be documented? Release noted? Is there any build option to set it so someone doesn't have to circumvent the b

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Roger Riggs
Hi, That's a pretty cryptic property, where will it be documented? Release noted? Is there any build option to set it so someone doesn't have to circumvent the build system to get the effect? Thanks, Roger On 5/10/2017 12:42 PM, Kumar Srinivasan wrote: Hi, Please review fix for the custo

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread David Holmes
On 11/05/2017 3:18 AM, Kumar Srinivasan wrote: On 5/10/2017 9:51 AM, Erik Joelsson wrote: Should this be set on the javadoc command line somewhere or am I missing something? Yes, one would have to set this prop, via the build system, when performing a non-oracle build. Shouldn't that be inv

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread Kumar Srinivasan
On 5/10/2017 9:51 AM, Erik Joelsson wrote: Should this be set on the javadoc command line somewhere or am I missing something? Yes, one would have to set this prop, via the build system, when performing a non-oracle build. Kumar /Erik On 2017-05-10 09:42, Kumar Srinivasan wrote: Hi, Pl

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread Erik Joelsson
Should this be set on the javadoc command line somewhere or am I missing something? /Erik On 2017-05-10 09:42, Kumar Srinivasan wrote: Hi, Please review fix for the custom taglet to allow openjdk builds, in which case the property "build.tools.taglet.ExtLink.NO_LINK" must be set to inhibit

RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread Kumar Srinivasan
Hi, Please review fix for the custom taglet to allow openjdk builds, in which case the property "build.tools.taglet.ExtLink.NO_LINK" must be set to inhibit server side lookups. Thanks Kumar Webrev: http://cr.openjdk.java.net/~ksrini/8179915/webrev.0 JBS: https://bugs.openjdk.java.net/browse/