Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Thanks Erik! Best regards, Robin > On 28 Mar 2018, at 17:47, Erik Joelsson wrote: > > I will sponsor the change. > > /Erik > > > On 2018-03-28 06:43, Robin Westberg wrote: >> Hi Kim, >> >>> On 26 Mar 2018, at 18:34, Kim Barrett wrote: >>> On Mar 26, 2018, at 11:01 AM, Robin Westberg

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

I will sponsor the change. /Erik On 2018-03-28 06:43, Robin Westberg wrote: Hi Kim, On 26 Mar 2018, at 18:34, Kim Barrett wrote: On Mar 26, 2018, at 11:01 AM, Robin Westberg wrote: Hi all, Please review this small change that defines the NOMINMAX macro when building HotSpot on Windows

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Hi Kim, > On 26 Mar 2018, at 18:34, Kim Barrett wrote: > >> On Mar 26, 2018, at 11:01 AM, Robin Westberg >> wrote: >> >> Hi all, >> >> Please review this small change that defines the NOMINMAX macro when >> building HotSpot on Windows. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Hi Magnus, Thanks for the review! Best regards, Robin > On 26 Mar 2018, at 23:24, Magnus Ihse Bursie > wrote: > > On 2018-03-26 17:01, Robin Westberg wrote: >> Hi all, >> >> Please review this small change that defines the NOMINMAX macro when >> building HotSpot on Windows. >> >> Issue: ht

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Hi Erik, Thanks for reviewing! Best regards, Robin > On 26 Mar 2018, at 17:50, Erik Joelsson wrote: > > Looks good. > > /Erik > > > On 2018-03-26 08:01, Robin Westberg wrote: >> Hi all, >> >> Please review this small change that defines the NOMINMAX macro when >> building HotSpot on Windo

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

On 2018-03-26 17:01, Robin Westberg wrote: Hi all, Please review this small change that defines the NOMINMAX macro when building HotSpot on Windows. Issue: https://bugs.openjdk.java.net/browse/JDK-8199619 Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

> On Mar 26, 2018, at 11:01 AM, Robin Westberg > wrote: > > Hi all, > > Please review this small change that defines the NOMINMAX macro when building > HotSpot on Windows. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8199619 > Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webre

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Looks good. /Erik On 2018-03-26 08:01, Robin Westberg wrote: Hi all, Please review this small change that defines the NOMINMAX macro when building HotSpot on Windows. Issue: https://bugs.openjdk.java.net/browse/JDK-8199619 Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/

RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Hi all, Please review this small change that defines the NOMINMAX macro when building HotSpot on Windows. Issue: https://bugs.openjdk.java.net/browse/JDK-8199619 Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/ Testing: