Re: RFR: 8205945 - Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk

2018-06-27 Thread Erik Joelsson
Looks good to me. /Erik On 2018-06-27 12:50, Daniel Fuchs wrote: [resending with correct subject] Hi, https://bugs.openjdk.java.net/browse/JDK-8205945 8205945: Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk My fix forĀ  8205397 [1] includes a change to

Re: RFR: 8205945 - Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk

2018-06-27 Thread Jonathan Gibbons
Looks OK to me, although I don't normally review hotspot or build changes. -- Jon On 6/27/18 12:50 PM, Daniel Fuchs wrote: [resending with correct subject] Hi, https://bugs.openjdk.java.net/browse/JDK-8205945 8205945: Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk

RFR: 8205945 - Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk

2018-06-27 Thread Daniel Fuchs
[resending with correct subject] Hi, https://bugs.openjdk.java.net/browse/JDK-8205945 8205945: Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk My fix for 8205397 [1] includes a change to make/gensrc/Gensrc-jdk.hotspot.agent.gmk that was not intended: diff --git