> On Nov 12, 2018, at 4:11 PM, JC Beyler wrote:
>
> Hi all,
>
> I created this change instead:
> http://cr.openjdk.java.net/~jcbeyler/8213622/webrev.00/
test/hotspot/jtreg/vmTestbase/nsk/share/jni/ExceptionCheckingJniEnv.cpp
80 full_message[len] = '\0’;
That should be
80
Hi,
On 11/13/18 1:08 AM, JC Beyler wrote:
Hi all,
@Mark: good point, fixed in the new webrev
@David: also good point, just because originally it was written differently
and I moved the code to this format and didn't move the +1 to the "right"
spot
@Michal: do you mind if I take over the bug
Hi Jc,
On 13/11/2018 10:50 AM, JC Beyler wrote:
Hi David,
Yes sorry, I had not seen that Mark Ludwig had only sent to me his
comment that included this part: "if you're going to bother with
strlen(), you know exactly how many bytes to copy, so don't use any
strXXX API at all - just
Hi David,
Yes sorry, I had not seen that Mark Ludwig had only sent to me his comment
that included this part: "if you're going to bother with strlen(), you know
exactly how many bytes to copy, so don't use any strXXX API at all - just
memcpy()."
Does that make sense?
Thanks,
Jc
On Mon, Nov 12,
Hi Jc,
On 13/11/2018 10:08 AM, JC Beyler wrote:
Hi all,
@Mark: good point, fixed in the new webrev
I assume this was the strncpy -> memcpy change as I haven't see any
email from Mark. What was the issue?
Update is fine anyway.
Thanks,
David
-
@David: also good point, just because
Hi Jc,
This seems okay to me. Only minor query is why you do the +1 (presumably
for terminating NUL) on the return_len instead of len ?
Thanks,
David
On 13/11/2018 7:11 AM, JC Beyler wrote:
Hi all,
I created this change instead:
http://cr.openjdk.java.net/~jcbeyler/8213622/webrev.00/
Hi Michal,
On 12/11/2018 2:18 PM, Michal Vala wrote:
On 11/10/18 12:07 AM, David Holmes wrote:
cc'ing JC Beyler as this was his code.
On 10/11/2018 4:35 AM, Kim Barrett wrote:
On Nov 9, 2018, at 11:43 AM, Michal Vala wrote:
Hi,
please review following patch fixing build failure on
> On Nov 9, 2018, at 6:07 PM, David Holmes wrote:
>
> cc'ing JC Beyler as this was his code.
>
> On 10/11/2018 4:35 AM, Kim Barrett wrote:
>>> On Nov 9, 2018, at 11:43 AM, Michal Vala wrote:
>>>
>>> Hi,
>>>
>>> please review following patch fixing build failure on Windows with VS2013
>>>
On 11/10/18 12:07 AM, David Holmes wrote:
cc'ing JC Beyler as this was his code.
On 10/11/2018 4:35 AM, Kim Barrett wrote:
On Nov 9, 2018, at 11:43 AM, Michal Vala wrote:
Hi,
please review following patch fixing build failure on Windows with VS2013
toolchain.
Not sure we're still
cc'ing JC Beyler as this was his code.
On 10/11/2018 4:35 AM, Kim Barrett wrote:
On Nov 9, 2018, at 11:43 AM, Michal Vala wrote:
Hi,
please review following patch fixing build failure on Windows with VS2013
toolchain.
Not sure we're still supporting VS2013 ... ??
> On Nov 9, 2018, at 11:43 AM, Michal Vala wrote:
>
> Hi,
>
> please review following patch fixing build failure on Windows with VS2013
> toolchain.
>
> http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8213622/webrev.00/
The failure is in a hotspot test. It should be using os::snprintf.
Hi,
please review following patch fixing build failure on Windows with VS2013
toolchain.
http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8213622/webrev.00/
--
Michal Vala
OpenJDK QE
Red Hat Czech
12 matches
Mail list logo
