RFR: 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2019-11-20 Thread christoph . goettschkes
Hi, please review the following change. Bug: https://bugs.openjdk.java.net/browse/JDK-8234535 Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev.00/ The removed lines are completely out of place and have no use at all. for the CC variable, for instance, the script does the following: CC_O

Re: RFR: 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2019-11-22 Thread Erik Joelsson
Hello Christoph, On 2019-11-20 10:22, christoph.goettsch...@microdoc.com wrote: Hi, please review the following change. Bug: https://bugs.openjdk.java.net/browse/JDK-8234535 Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev.00/ The removed lines are completely out of place and have no u

Re: RFR: 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2019-11-26 Thread christoph . goettschkes
2019-11-22 17:19:08: > From: Erik Joelsson > To: christoph.goettsch...@microdoc.com, build-dev@openjdk.java.net > Date: 2019-11-22 17:19 > Subject: Re: RFR: 8234535: Cross compilation fails due to missing > CFLAGS for the BUILD_CC > > Hello Christoph, > > On 2019-11-2

Re: RFR: 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2019-11-26 Thread Erik Joelsson
commit it into the repository for me? Thanks, Christoph Erik Joelsson wrote on 2019-11-22 17:19:08: From: Erik Joelsson To: christoph.goettsch...@microdoc.com, build-dev@openjdk.java.net Date: 2019-11-22 17:19 Subject: Re: RFR: 8234535: Cross compilation fails due to missing CFLAGS for the

[ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Christoph Göttschkes
Hi, the webrev below still applies cleanly to jdk11u-dev. Could someone please review this downport? Thanks, Christoph On 2020-07-20 15:48, Christoph Göttschkes wrote: Hi, please review this downport of JDK-8234535 to jdk11u-dev. The changeset does not apply cleanly because of unrelated di

Re: [ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Severin Gehwolf
On Wed, 2020-08-26 at 11:29 +0200, Christoph Göttschkes wrote: > > Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev-11u.00/ This looks fine to me. Thanks, Severin

Re: [ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Christoph Göttschkes
Thank you for the quick review, Severin. -- Christoph On 2020-08-26 12:10, Severin Gehwolf wrote: On Wed, 2020-08-26 at 11:29 +0200, Christoph Göttschkes wrote: Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev-11u.00/ This looks fine to me. Thanks, Severin