#x27;
Cc: 'hotspot-...@openjdk.java.net' ; Baesken,
Matthias
Subject: Re: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk
images
Hello Christoph,
Thanks for hanging in there, this is now looking good to me. Nice to see a more
general solution to the java.pdb problem.
/Erik
...@openjdk.java.net' <mailto:hotspot-...@openjdk.java.net>>; Baesken, Matthias
mailto:matthias.baes...@sap.com>>
*Subject:* Re: RFR: 8237192: Generate stripped/public pdbs on Windows
for jdk images
Hello Christoph,
This patch certainly looks better to me, though I agree it&#x
penjdk.java.net' ; Baesken,
Matthias
Subject: RE: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk
images
Hi Erik,
thanks for your review. While I’ve addressed all your points (thanks for the
great hints regarding usage of SetupCopyFiles), I also enhanced the configure
option a l
Cc: 'hotspot-...@openjdk.java.net' ; Baesken,
Matthias
Subject: Re: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk
images
Hello Christoph,
This patch certainly looks better to me, though I agree it's a bit hackish to
have to filter and rename the stripped.pdb files twice,
Hi Alan,
> On 12/02/2020 22:16, Erik Joelsson wrote:
> > Hello Christoph,
> >
> > This patch certainly looks better to me, though I agree it's a bit
> > hackish to have to filter and rename the stripped.pdb files twice,
> > once for jmods and again for bundles. I think I'm ok with it for now
> > t
On 12/02/2020 22:16, Erik Joelsson wrote:
Hello Christoph,
This patch certainly looks better to me, though I agree it's a bit
hackish to have to filter and rename the stripped.pdb files twice,
once for jmods and again for bundles. I think I'm ok with it for now
though. The future improvement
lmes ;
'build-dev@openjdk.java.net' ;
'hotspot-...@openjdk.java.net'
*Subject:* Re: RFR: 8237192: Generate stripped/public pdbs on Windows
for jdk images
On 2020-02-07 09:50, Baesken, Matthias wrote:
Hello, here is a slightly changed new webrev :
http://cr.
t;mailto:david.hol...@oracle.com>;
'build-
d...@openjdk.java.net<mailto:d...@openjdk.java.net>'<mailto:build-dev@openjdk.java.net>;
'hotspot-
d...@openjdk.java.net<mailto:d...@openjdk.java.net>'<mailto:hotspot-...@openjdk.java.net>
Subject: RE: RFR: 8237192: Generate stripped/public pdbs on
Windows
for
jdk images
Hi David , yes I think it makes sense to have a configure option for
this .
Not everyone would like to have a larger JDK (even it is only a bit
larger).
heavy penalty in added code complexity.
/Erik
/Magnus
Thanks
Christoph
-Original Message-
From: build-dev On Behalf Of
Erik
Joelsson
Sent: Donnerstag, 23. Januar 2020 18:49
To: Baesken, Matthias; David Holmes
; 'build-dev@openjdk.java.net' ; 'hotspot-...@openjdk.j
> >>>
> >>>>> To properly implement this, care will need to be taken to juggle the
> two
> >>>>> sets of pdb files around, making sure each build and test use case has
> >>>>> the correct one in place where and when it's need
On Behalf Of Erik
Joelsson
Sent: Donnerstag, 23. Januar 2020 18:49
To: Baesken, Matthias; David Holmes
; 'build-dev@openjdk.java.net' ; 'hotspot-...@openjdk.java.net'
Subject: Re: RFR: 8237192: Generate stripped/public pdbs on Windows for
jdk images
On 2020-01-23 00:03, Baesk
Thanks
Christoph
-Original Message-
From: build-dev On Behalf Of Erik
Joelsson
Sent: Donnerstag, 23. Januar 2020 18:49
To: Baesken, Matthias ; David Holmes
; 'build-dev@openjdk.java.net' ; 'hotspot-...@openjdk.java.net'
Subject: Re: RFR: 8237192: Generate stripped/publ
David Holmes
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>
> Subject: Re: RFR: 8237192: Generate stripped/public pdbs on Windows for
> jdk images
>
>
> On 2020-01-23 00:03, Baesken, Matth
>
> Hi Erik, maybe we can just rename the configure option to
>
> --enable-stripped-pdbs-for-bundle
>
> AND make the default = no/false .
> Then without setting the configure flag, everything stays as it is for JDK
> vendors/distributors who do not want the stripped pdbs in the bundle.
>
>>
> >> On 2020-01-22 07:46, Baesken, Matthias wrote:
> >>> Hello, here is an updated version :
> >>>
> >>> http://cr.openjdk.java.net/~mbaesken/webrevs/8237192.3/
> >>>
> >>> this one supports a configure switch &q
Holmes' ; 'build-
d...@openjdk.java.net' ; 'hotspot-
d...@openjdk.java.net'
Subject: RE: RFR: 8237192: Generate stripped/public pdbs on Windows for
jdk images
Hi David , yes I think it makes sense to have a configure option for this .
Not everyone would like to have a larger JDK (even it is only a bit larger).
; the feature .
> >
> > Best regards, Matthias
> >
> >
> >> -Original Message-
> >> From: Baesken, Matthias
> >> Sent: Dienstag, 21. Januar 2020 11:03
> >> To: 'David Holmes' ; 'build-
> >> d...@openjdk.java.n
e
feature .
Best regards, Matthias
-Original Message-
From: Baesken, Matthias
Sent: Dienstag, 21. Januar 2020 11:03
To: 'David Holmes' ; 'build-
d...@openjdk.java.net' ; 'hotspot-
d...@openjdk.java.net'
Subject: RE: RFR: 8237192: Generate stripped/public p
ienstag, 21. Januar 2020 11:03
> To: 'David Holmes' ; 'build-
> d...@openjdk.java.net' ; 'hotspot-
> d...@openjdk.java.net'
> Subject: RE: RFR: 8237192: Generate stripped/public pdbs on Windows for
> jdk images
>
>
> Hi David , yes I think
Hi David , yes I think it makes sense to have a configure option for this .
Not everyone would like to have a larger JDK (even it is only a bit larger).
Best regards, Matthias
>
> Hi Matthias,
>
> This also needs to be a configurable option not one done by default as
> there can be non-techn
Hi Matthias,
This also needs to be a configurable option not one done by default as
there can be non-technical issues relating to shipping symbol files in a
product.
Thanks,
David
On 17/01/2020 6:44 pm, Baesken, Matthias wrote:
Hello, please review this change related to stripped/"public" p
Hello Matthias,
Providing these stripped pdb files in the distribution is a good idea,
but finding a good solution in the build is unfortunately more
complicated than this. The JDK image we ship should (with very few
exceptions) be the result of running jlink on all the jmods. If a user
runs
Hello, my example product build (64 bit Windows / VS2017) shows the following
sizes for the uncompressed pdb files :
sum of size of all full pdbs : 117 MB (jvm.pdb is 73,1 MB )
sum of size of all stripped pdbs: 18,2 MB (jvm.pdb is 9,46 MB = ~ 50 % of all)
Best regards, Matthias
On 2020-01-17 0
On 2020-01-17 09:44, Baesken, Matthias wrote:
Hello, please review this change related to stripped/"public" pdb file
generation on Windows .
Currently the JDK bundle on Windows does not contain pdb files (full pdb files
are in a separate symbols bundle).
This leads currently to bad native stac
Hello, please review this change related to stripped/"public" pdb file
generation on Windows .
Currently the JDK bundle on Windows does not contain pdb files (full pdb files
are in a separate symbols bundle).
This leads currently to bad native stack traces e.g. when crashes occur.
One reason not
25 matches
Mail list logo
