Re: RFR: 8237566: FindTests.gmk should only include existing TEST.ROOT files

2020-02-18 Thread Erik Joelsson
Looks good. /Erik On 2020-02-14 05:51, Erik Helin wrote: On 2/13/20 6:21 PM, Erik Joelsson wrote: Hello Erik, Looks good. Thanks for reviewing! On 2/13/20 6:21 PM, Erik Joelsson wrote: Style wise I try to put closing braces for logical blocks on a new line, aligned with the opening brace.

Re: RFR: 8237566: FindTests.gmk should only include existing TEST.ROOT files

2020-02-14 Thread Erik Helin
On 2/13/20 6:21 PM, Erik Joelsson wrote: Hello Erik, Looks good. Thanks for reviewing! On 2/13/20 6:21 PM, Erik Joelsson wrote: Style wise I try to put closing braces for logical blocks on a new line, aligned with the opening brace. I think that helps making the already quite convoluted mak

Re: RFR: 8237566: FindTests.gmk should only include existing TEST.ROOT files

2020-02-13 Thread Erik Joelsson
Hello Erik, Looks good. Style wise I try to put closing braces for logical blocks on a new line, aligned with the opening brace. I think that helps making the already quite convoluted makefile logic a tad more readable. /Erik On 2020-02-13 04:44, Erik Helin wrote: Hi all, this small patch

RFR: 8237566: FindTests.gmk should only include existing TEST.ROOT files

2020-02-13 Thread Erik Helin
Hi all, this small patch changes FindTest.gmk to only include TEST.ROOT files that actually are present. The motivation for this change is that both Git and Mercurial supports so called "sparse" checkouts [0][1] (still somewhat experimental for both, but actively worked on). While experimenti