Re: RFR: 8239357: Revert gcc implementation of offset_of

2020-04-23 Thread Kim Barrett
> On Apr 22, 2020, at 9:28 AM, Erik Joelsson wrote: > > Build change looks good. Thanks. > > /Erik > > On 2020-04-22 06:23, Kim Barrett wrote: >> Please review this change to undo the (small) portion of JDK-8238281 >> [1] related to the HotSpot offset_of macro for gcc/clang. That change >> s

Re: RFR: 8239357: Revert gcc implementation of offset_of

2020-04-23 Thread Kim Barrett
> On Apr 22, 2020, at 9:57 AM, Magnus Ihse Bursie > wrote: > > On 2020-04-22 15:23, Kim Barrett wrote: >> Please review this change to undo the (small) portion of JDK-8238281 >> [1] related to the HotSpot offset_of macro for gcc/clang. That change >> should not have been made. See CR for detai

Re: RFR: 8239357: Revert gcc implementation of offset_of

2020-04-23 Thread Kim Barrett
> On Apr 22, 2020, at 10:33 PM, David Holmes wrote: > > On 22/04/2020 11:23 pm, Kim Barrett wrote: >> Please review this change to undo the (small) portion of JDK-8238281 >> [1] related to the HotSpot offset_of macro for gcc/clang. That change >> should not have been made. See CR for details. >

Re: RFR: 8239357: Revert gcc implementation of offset_of

2020-04-22 Thread David Holmes
On 22/04/2020 11:23 pm, Kim Barrett wrote: Please review this change to undo the (small) portion of JDK-8238281 [1] related to the HotSpot offset_of macro for gcc/clang. That change should not have been made. See CR for details. I did not reinstate the redefinition of offsetof; we shouldn't be

Re: RFR: 8239357: Revert gcc implementation of offset_of

2020-04-22 Thread Magnus Ihse Bursie
On 2020-04-22 15:23, Kim Barrett wrote: Please review this change to undo the (small) portion of JDK-8238281 [1] related to the HotSpot offset_of macro for gcc/clang. That change should not have been made. See CR for details. I did not reinstate the redefinition of offsetof; we shouldn't be us

Re: RFR: 8239357: Revert gcc implementation of offset_of

2020-04-22 Thread Erik Joelsson
Build change looks good. /Erik On 2020-04-22 06:23, Kim Barrett wrote: Please review this change to undo the (small) portion of JDK-8238281 [1] related to the HotSpot offset_of macro for gcc/clang. That change should not have been made. See CR for details. I did not reinstate the redefinitio

RFR: 8239357: Revert gcc implementation of offset_of

2020-04-22 Thread Kim Barrett
Please review this change to undo the (small) portion of JDK-8238281 [1] related to the HotSpot offset_of macro for gcc/clang. That change should not have been made. See CR for details. I did not reinstate the redefinition of offsetof; we shouldn't be using that macro, and having the warning ena