Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-04-08 Thread Christian Hagedorn
On Wed, 26 Jan 2022 14:23:14 GMT, Erik Joelsson wrote: >> Christian Hagedorn has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update test/hotspot/jtreg/runtime/ErrorHandling/TestDwarf.java >> >>Co-authored-by: Erik Joelsson

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Zhengyu Gu
On Fri, 28 Jan 2022 09:38:14 GMT, Christian Hagedorn wrote: > > > That's interesting. Is this implementation still around somewhere? I'm > > > glad that some of the mentioned things are not a problem anymore. > > > > > > Not I know. IIRC, it was based on DWARF 2. > > Okay, thanks. > > > >

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Fri, 28 Jan 2022 09:58:26 GMT, Thomas Stuefe wrote: > > > Two general remarks. One concern I have is that the new functionality > > > should be super stable, since nothing is more annoying than to crash > > > during stack dumping in hs-err file; I much rather have a call stack > > >

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Thomas Stuefe
On Fri, 28 Jan 2022 09:19:04 GMT, Christian Hagedorn wrote: > > Two general remarks. One concern I have is that the new functionality > > should be super stable, since nothing is more annoying than to crash during > > stack dumping in hs-err file; I much rather have a call stack without bells

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Fri, 28 Jan 2022 02:26:21 GMT, Yasumasa Suenaga wrote: > I think this feature is very useful, thanks Christian! Thanks Yasumasa! > SA already has similar feature to gather call stacks with DWARF, so it would > be nice to share DWARF parser between SA and HotSpot. I agree, that would be a

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Thu, 27 Jan 2022 13:43:00 GMT, Zhengyu Gu wrote: > > That's interesting. Is this implementation still around somewhere? I'm glad > > that some of the mentioned things are not a problem anymore. > > Not I know. IIRC, it was based on DWARF 2. Okay, thanks. > > > > * Different compiler (and

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Thu, 27 Jan 2022 09:26:50 GMT, Thomas Stuefe wrote: > Hi Christian, this is very nice and useful! Thanks Thomas! > Two general remarks. One concern I have is that the new functionality should > be super stable, since nothing is more annoying than to crash during stack > dumping in hs-err

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-27 Thread Yasumasa Suenaga
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-27 Thread Zhengyu Gu
On Thu, 27 Jan 2022 08:38:02 GMT, Christian Hagedorn wrote: > > Build changes look good. > > Thanks Erik! > > > Personally, I am in favor of this project. Actually, I were experimenting > > it with libdwarf. > > I would like to add some historical background on this topic, just for > >

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-27 Thread Thomas Stuefe
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-27 Thread Christian Hagedorn
On Tue, 25 Jan 2022 15:06:41 GMT, Christian Hagedorn wrote: > Build changes look good. Thanks Erik! > Personally, I am in favor of this project. Actually, I were experimenting it > with libdwarf. > > I would like to add some historical background on this topic, just for > consideration.

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-26 Thread Erik Joelsson
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-26 Thread Zhengyu Gu
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-25 Thread Christian Hagedorn
On Tue, 25 Jan 2022 14:00:49 GMT, Erik Joelsson wrote: > Build changes look good. The reference to the new env variable is missing the > initial underscore in two places. Thanks Erik for reviewing the build changes. I updated the places. - PR:

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-25 Thread Christian Hagedorn
> When printing the native stack trace on Linux (mostly done for hs_err files), > it only prints the method with its parameters and a relative offset in the > method: > > Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e01838110, free > space=1020k > Native frames: (J=compiled