Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Kim Barrett
> On Aug 13, 2020, at 6:54 AM, Magnus Ihse Bursie > wrote: > > On 2020-08-13 09:15, Kim Barrett wrote: >> I'm similarly surprised by this pre-existing bit in CoreLibraries.gmk: >> >> $(eval $(call SetupJdkLibrary, BUILD_LIBJIMAGE, \ >> ... >> LIBS_unix := -ljvm -ldl $(LIBCXX), \ >>

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Magnus Ihse Bursie
On 2020-08-13 09:15, Kim Barrett wrote: On Aug 1, 2020, at 3:24 AM, Vladimir Kempik wrote: Hello Please review this change for JDK-8250876 This changeset adds support for macos/aarch64 into build system. It will allow to crosscompile for macos/aarch64 using intel mac as well. This changeset

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Kim Barrett
> On Aug 13, 2020, at 3:15 AM, Kim Barrett wrote: > >> On Aug 1, 2020, at 3:24 AM, Vladimir Kempik wrote: >> >> Hello >> >> Please review this change for JDK-8250876 >> >> This changeset adds support for macos/aarch64 into build system. >> It will allow to crosscompile for macos/aarch64

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Kim Barrett
> On Aug 1, 2020, at 3:24 AM, Vladimir Kempik wrote: > > Hello > > Please review this change for JDK-8250876 > > This changeset adds support for macos/aarch64 into build system. > It will allow to crosscompile for macos/aarch64 using intel mac as well. > > This changeset does NOT address some

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Erik Joelsson
ndrew Brygin; Andrey Petushkov Subject: Re: RFR: 8250876: Build system preparation to macos on aarch64 On 3/08/2020 10:57 pm, Erik Joelsson wrote: Hello Vladimir, These changes look innocent enough to me. They aren't actually adding macosx-aarch64 support, they are just removing two minor (and

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Vladimir Kempik
gt; -UTIL_REQUIRE_PROGS(BUILD_CXX, [cl CC g++]) >>>>> +UTIL_REQUIRE_PROGS(BUILD_CXX, [clang++ cl CC g++]) >>>>> UTIL_FIXUP_EXECUTABLE(BUILD_CXX) >>>>> UTIL_PATH_PROGS(BUILD_NM, nm gcc-nm) >>>>> UTIL_FIXUP_EXE

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Erik Joelsson
on behalf of David Holmes mailto:david.hol...@oracle.com>> Sent: Tuesday, August 4, 2020 00:46 To: Erik Joelsson; Vladimir Kempik; build-dev Cc: Anton Kozlov; Alexander Ioffe; Andrew Brygin; Andrey Petushkov Subject: Re: RFR: 8250876: Build system preparation to macos on aarch64 On 3/08/2020

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Vladimir Kempik
t; -UTIL_REQUIRE_PROGS(BUILD_CXX, [cl CC g++]) >>>>> +UTIL_REQUIRE_PROGS(BUILD_CXX, [clang++ cl CC g++]) >>>>> UTIL_FIXUP_EXECUTABLE(BUILD_CXX) >>>>> UTIL_PATH_PROGS(BUILD_NM, nm gcc-nm) >>>>> UTIL_FIXUP_EXECUTABLE(BUILD_

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Erik Joelsson
enjdk.java.net>> on behalf of David Holmes mailto:david.hol...@oracle.com>> Sent: Tuesday, August 4, 2020 00:46 To: Erik Joelsson; Vladimir Kempik; build-dev Cc: Anton Kozlov; Alexander Ioffe; Andrew Brygin; Andrey Petushkov Subject: Re: RFR: 8250876: Build system preparation to macos

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Vladimir Kempik
_FIXUP_EXECUTABLE(BUILD_CXX) >>> UTIL_PATH_PROGS(BUILD_NM, nm gcc-nm) >>> UTIL_FIXUP_EXECUTABLE(BUILD_NM) >>> >>> Although I'm not sure about its cleanliness :-) >>> >>> -Bernhard >>> >>> ___

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Magnus Ihse Bursie
iness :-) -Bernhard From: build-dev on behalf of David Holmes Sent: Tuesday, August 4, 2020 00:46 To: Erik Joelsson; Vladimir Kempik; build-dev Cc: Anton Kozlov; Alexander Ioffe; Andrew Brygin; Andrey Petushkov Subject: Re: RFR: 8250876: Build system preparation

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-04 Thread David Holmes
Brygin; Andrey Petushkov Subject: Re: RFR: 8250876: Build system preparation to macos on aarch64 On 3/08/2020 10:57 pm, Erik Joelsson wrote: Hello Vladimir, These changes look innocent enough to me. They aren't actually adding macosx-aarch64 support, they are just removing two minor (and more likely

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-04 Thread Erik Joelsson
: 8250876: Build system preparation to macos on aarch64 On 3/08/2020 10:57 pm, Erik Joelsson wrote: Hello Vladimir, These changes look innocent enough to me. They aren't actually adding macosx-aarch64 support, they are just removing two minor (and more likely OS version related) hurdles from

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-04 Thread Bernhard Urban-Forster
of David Holmes Sent: Tuesday, August 4, 2020 00:46 To: Erik Joelsson; Vladimir Kempik; build-dev Cc: Anton Kozlov; Alexander Ioffe; Andrew Brygin; Andrey Petushkov Subject: Re: RFR: 8250876: Build system preparation to macos on aarch64 On 3/08/2020 10:57 pm, Erik Joelsson wrote: > Hello Vladi

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-03 Thread David Holmes
On 3/08/2020 10:57 pm, Erik Joelsson wrote: Hello Vladimir, These changes look innocent enough to me. They aren't actually adding macosx-aarch64 support, they are just removing two minor (and more likely OS version related) hurdles from the build. You still have to provide the actual

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-03 Thread Erik Joelsson
Hello Vladimir, These changes look innocent enough to me. They aren't actually adding macosx-aarch64 support, they are just removing two minor (and more likely OS version related) hurdles from the build. You still have to provide the actual configuration on the configure command line as is

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-02 Thread David Holmes
Hi Vladimir, On 1/08/2020 5:24 pm, Vladimir Kempik wrote: Hello Please review this change for JDK-8250876 This changeset adds support for macos/aarch64 into build system. macOS/Aarch64 is not yet an accepted platform for the OpenJDK. Adding such a platform requires a JEP as is being done

RFR: 8250876: Build system preparation to macos on aarch64

2020-08-01 Thread Vladimir Kempik
Hello Please review this change for JDK-8250876 This changeset adds support for macos/aarch64 into build system. It will allow to crosscompile for macos/aarch64 using intel mac as well. This changeset does NOT address some arm specific issues in the macos related code, we plan to do that in s