Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-15 Thread Roman Kennke
On Thu, 10 Sep 2020 15:30:04 GMT, Monica Beckwith wrote: >> ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will >> enable and run microbenchmarks and scaling >> tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015 >> (heap and multi-JVM) scaling tests

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-11 Thread Stuart Monteith
On 11/09/2020 04:48, Monica Beckwith wrote: On Thu, 10 Sep 2020 17:09:00 GMT, Monica Beckwith wrote: This looks good to me with Alexsey's changes applied. Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743 Hi David, Thanks. I wanted to start a conversation here as it does mod

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-11 Thread Stefan Karlsson
On Thu, 10 Sep 2020 15:30:04 GMT, Monica Beckwith wrote: >> ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will >> enable and run microbenchmarks and scaling >> tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015 >> (heap and multi-JVM) scaling tests

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread Aleksey Shipilev
On Fri, 11 Sep 2020 06:21:46 GMT, Aleksey Shipilev wrote: >> Monica Beckwith has updated the pull request incrementally with one >> additional commit since the last revision: >> >> x$OPENJDK_TARGET_CPU" = "xaarch64" >> >> Incorporating Aleksey's comments to incorporate 'x' > > The check

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread Aleksey Shipilev
On Thu, 10 Sep 2020 15:30:04 GMT, Monica Beckwith wrote: >> ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will >> enable and run microbenchmarks and scaling >> tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015 >> (heap and multi-JVM) scaling tests

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread Monica Beckwith
On Thu, 10 Sep 2020 17:09:00 GMT, Monica Beckwith wrote: >> This looks good to me with Alexsey's changes applied. > > Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743 > Hi David, > Thanks. I wanted to start a conversation here as it does modify common code > (the aarch64-linux

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread David Holmes
Hi Monica, On 11/09/2020 3:11 am, Monica Beckwith wrote: Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743 Hi David, Thanks. I wanted to start a conversation here as it does modify common code (the aarch64-linux combo check) and also wanted to highlight the difference between S

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread Monica Beckwith
On Thu, 10 Sep 2020 16:28:34 GMT, Stuart Monteith wrote: >>> Ah, Shenandoah does not filter for OS, so it is enabled for AArch64 >>> already, right? >> >> +1 > > This looks good to me with Alexsey's changes applied. Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743 Hi David, T

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread Stuart Monteith
On Thu, 10 Sep 2020 05:16:00 GMT, Monica Beckwith wrote: >> Ah, Shenandoah does not filter for OS, so it is enabled for AArch64 already, >> right? > >> Ah, Shenandoah does not filter for OS, so it is enabled for AArch64 already, >> right? > > +1 This looks good to me with Alexsey's changes ap

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread Monica Beckwith
On Thu, 10 Sep 2020 05:09:25 GMT, Aleksey Shipilev wrote: >> Monica Beckwith has updated the pull request incrementally with one >> additional commit since the last revision: >> >> x$OPENJDK_TARGET_CPU" = "xaarch64" >> >> Incorporating Aleksey's comments to incorporate 'x' > > make/autoc

Re: RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2]

2020-09-10 Thread Monica Beckwith
> ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will > enable and run microbenchmarks and scaling > tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015 > (heap and multi-JVM) scaling tests for both > the GCs. Monica Beckwith has updated the pull requ