Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

2020-10-08 Thread Robin Westberg
On Thu, 8 Oct 2020 07:12:12 GMT, Aleksey Shipilev wrote: >> That makes sense. We should change the order in #547 then first? So the >> final thing would be: >> >> - build release >> - build debug >> - build hotspot no-pch debug >> - build hotspot zero no-pch debug >> - build hotspot minimal no-

Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

2020-10-08 Thread Aleksey Shipilev
On Thu, 8 Oct 2020 07:08:46 GMT, Aleksey Shipilev wrote: >> .github/workflows/submit.yml line 109: >> >>> 107: - build debug >>> 108: - build hotspot no-pch >>> 109: - build debug hotspot no-pch zero >> >> Suggestion: >> >> - build hotspot zero no-pch de

Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

2020-10-08 Thread Aleksey Shipilev
On Thu, 8 Oct 2020 06:58:38 GMT, Robin Westberg wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Build with debug and no-pch for zero and minimal > > .github/workflows/submit.yml line 109: > >> 107: -

Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

2020-10-08 Thread Robin Westberg
On Wed, 7 Oct 2020 16:28:17 GMT, Aleksey Shipilev wrote: >> Zero VM and Minimal VM builds are routinely discovering the problems with >> internal Hotspot dependencies. Mostly because >> they turn off the whole lot of VM features, and every path that is not >> guarded by a feature #ifdef or buil

Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

2020-10-08 Thread Erik Joelsson
On Wed, 7 Oct 2020 16:28:17 GMT, Aleksey Shipilev wrote: >> Zero VM and Minimal VM builds are routinely discovering the problems with >> internal Hotspot dependencies. Mostly because >> they turn off the whole lot of VM features, and every path that is not >> guarded by a feature #ifdef or buil

Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

2020-10-07 Thread Aleksey Shipilev
> Zero VM and Minimal VM builds are routinely discovering the problems with > internal Hotspot dependencies. Mostly because > they turn off the whole lot of VM features, and every path that is not > guarded by a feature #ifdef or build file list > fails. It would be good to add Zero and Minimal