Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]

2020-11-26 Thread Aleksey Shipilev
On Thu, 26 Nov 2020 11:10:43 GMT, Ao Qi wrote: >> Thanks, I'll wait for either of @glaubitz, @theaoqi or @xiangzhai to confirm >> this fixes the native `mipsel` builds for them, and then integrate. > > The native build of linux-mipsel-zero-release passed. I only have mips64el > and 64-bit OS, s

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]

2020-11-26 Thread Ao Qi
On Wed, 25 Nov 2020 08:43:31 GMT, Aleksey Shipilev wrote: >> Marked as reviewed by ihse (Reviewer). > > Thanks, I'll wait for either of @glaubitz, @theaoqi or @xiangzhai to confirm > this fixes the native `mipsel` builds for them, and then integrate. The native build of linux-mipsel-zero-releas

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]

2020-11-25 Thread Aleksey Shipilev
On Tue, 24 Nov 2020 07:13:27 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains four commits: >> >> - Merge branch 'master' into JDK-8256831-mips-8-byte-cas >> - Move the library a

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]

2020-11-23 Thread Magnus Ihse Bursie
On Mon, 23 Nov 2020 22:35:05 GMT, Aleksey Shipilev wrote: >> If you try to build `linux-mipsel-zero-fastdebug`, this happens: >> >> >> >> >> >> >> >> I think it relates to >> [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that >> introduced `atomic_compare_exchange` on t

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]

2020-11-23 Thread Aleksey Shipilev
> If you try to build `linux-mipsel-zero-fastdebug`, this happens: > > > > > > > > I think it relates to > [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that > introduced `atomic_compare_exchange` on those paths, but maybe the issue > exists for longer. > > Various oth

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v2]

2020-11-23 Thread Aleksey Shipilev
On Mon, 23 Nov 2020 11:48:27 GMT, John Paul Adrian Glaubitz wrote: > As a heads-up. I have a working Loongson 2k board at home now (mips64el). So, > in case something needs to be tested natively on MIPS, let me know. Oh, cool! Can it build `mipsel`, not only `mips64el`? If so, please try to c

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v2]

2020-11-23 Thread Aleksey Shipilev
On Mon, 23 Nov 2020 11:37:14 GMT, Aleksey Shipilev wrote: > So, would adding to `BASIC_JVM_LIBS` at `LIB_SETUP_LIBRARIES` step in > `make/autoconf/libraries.m4` be a good place then? This seems to work. It would seem only JVM is needed to be built with `-latomic`, which makes sense, as the pro

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v2]

2020-11-23 Thread Aleksey Shipilev
> If you try to build `linux-mipsel-zero-fastdebug`, this happens: > > > > > > > > I think it relates to > [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that > introduced `atomic_compare_exchange` on those paths, but maybe the issue > exists for longer. > > Various oth

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8

2020-11-23 Thread John Paul Adrian Glaubitz
On Mon, 23 Nov 2020 11:41:08 GMT, Magnus Ihse Bursie wrote: >>> Otherwise this looks like something that belong in LIBJVM LIBS. In fact, if >>> it is _only_ needed for the hotspot build, it is really where it belong. >>> And even if it's needed in an additional library or two, it should be adde

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8

2020-11-23 Thread Magnus Ihse Bursie
On Mon, 23 Nov 2020 11:37:14 GMT, Aleksey Shipilev wrote: >> This is incorrect. The `-l` prefix indicates a library to link with. As >> such, it belongs to LIBS, not LDFLAGS. >> >> I'm not sure if we still have a global LIBS variable that is added to all >> compile lines. We used to have sinc

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8

2020-11-23 Thread Aleksey Shipilev
On Mon, 23 Nov 2020 11:28:05 GMT, Magnus Ihse Bursie wrote: >> If you try to build `linux-mipsel-zero-fastdebug`, this happens: >> >> >> >> >> >> >> >> I think it relates to >> [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that >> introduced `atomic_compare_exchange` on

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8

2020-11-23 Thread Magnus Ihse Bursie
On Sun, 22 Nov 2020 14:40:12 GMT, Aleksey Shipilev wrote: > If you try to build `linux-mipsel-zero-fastdebug`, this happens: > > > > > > > > I think it relates to > [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that > introduced `atomic_compare_exchange` on those paths,

Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8

2020-11-23 Thread Jie Fu
On Sun, 22 Nov 2020 14:40:12 GMT, Aleksey Shipilev wrote: > If you try to build `linux-mipsel-zero-fastdebug`, this happens: > > > > > > > > I think it relates to > [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that > introduced `atomic_compare_exchange` on those paths,

RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8

2020-11-22 Thread Aleksey Shipilev
If you try to build `linux-mipsel-zero-fastdebug`, this happens: I think it relates to [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that introduced `atomic_compare_exchange` on those paths, but maybe the issue exists for longer. Various other reports for build failure