Re: RFR: 8258857: Zero: non-PCH build fails after JDK-8258074

2020-12-25 Thread Jie Fu
On Sat, 26 Dec 2020 04:42:34 GMT, Hao Sun wrote: > Regarding the debug build, I guess it's because that flag 'pd_CICompileOSR' > is not used for debug build. > Please refer to > https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/globals_shared.hpp#L84 > > I suppose macro 'DE

Re: RFR: 8258857: Zero: non-PCH build fails after JDK-8258074

2020-12-25 Thread Jie Fu
On Fri, 25 Dec 2020 10:11:13 GMT, Hao Sun wrote: > From the error log we can see the root cause is that, develop_pd flag > 'pd_CICompileOSR' is undeclared in zero build. > > Where this flag is used? > Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77 > of 'compiler_globals.

Re: RFR: 8258857: Zero: non-PCH build fails after JDK-8258074

2020-12-25 Thread Hao Sun
On Fri, 25 Dec 2020 11:44:11 GMT, Jie Fu wrote: > Maybe, the title would be better with 'Zero: non-PCH release build fails > after JDK-8258074'. Hi Jie, thanks for your comment. Yes. Agree. It's much more accurate to describe this issue with 'release' added. Will rename it next Monday as I need

Re: RFR: 8258857: Zero: non-PCH build fails after JDK-8258074

2020-12-25 Thread Jie Fu
On Fri, 25 Dec 2020 10:11:13 GMT, Hao Sun wrote: > From the error log we can see the root cause is that, develop_pd flag > 'pd_CICompileOSR' is undeclared in zero build. > > Where this flag is used? > Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77 > of 'compiler_globals.

RFR: 8258857: Zero: non-PCH build fails after JDK-8258074

2020-12-25 Thread Hao Sun
>From the error log we can see the root cause is that, develop_pd flag 'pd_CICompileOSR' is undeclared in zero build. Where this flag is used? Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77 of 'compiler_globals.hpp' and further line 86 of 'globals_shared.hpp'. Where this f