On Tue, 5 Jan 2021 14:28:14 GMT, Hao Sun
wrote:
>> Marked as reviewed by jiefu (Committer).
>
> Thanks for your reviews! @DamonFool @iklam @shipilev
>
> The pre-submit tests were passed except the GC one which is not related to
> this patch. I suppose this patch is ready to be merged now.
Sp
On Tue, 5 Jan 2021 12:03:05 GMT, Jie Fu wrote:
>> Hao Sun has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Header 'runtime/globals_shared.hpp' should be kept
>>
>> Header 'runtime/globals_shared.hpp' is kept even though
>> 'compile
On Tue, 5 Jan 2021 12:06:18 GMT, Hao Sun
wrote:
>> From the error log we can see the root cause is that, develop_pd flag
>> 'pd_CICompileOSR' is undeclared in zero build.
>>
>> Where this flag is used?
>> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
>> of 'compiler_glo
On Tue, 5 Jan 2021 12:06:18 GMT, Hao Sun
wrote:
>> From the error log we can see the root cause is that, develop_pd flag
>> 'pd_CICompileOSR' is undeclared in zero build.
>>
>> Where this flag is used?
>> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
>> of 'compiler_glo
On Tue, 5 Jan 2021 12:06:18 GMT, Hao Sun
wrote:
>> From the error log we can see the root cause is that, develop_pd flag
>> 'pd_CICompileOSR' is undeclared in zero build.
>>
>> Where this flag is used?
>> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
>> of 'compiler_glo
On Tue, 5 Jan 2021 00:12:58 GMT, Ioi Lam wrote:
>>> `#include "runtime/globals_shared.hpp"` should not be removed.
>>> compiler_globals.hpp uses the `DECLARE_FLAGS` macro, which is defined by
>>> globals_shared.hpp.
>>
>> Since globals_shared.hpp is included in compiler_globals_pd.hpp, I think
On Tue, 5 Jan 2021 12:03:39 GMT, Hao Sun
wrote:
>> From the error log we can see the root cause is that, develop_pd flag
>> 'pd_CICompileOSR' is undeclared in zero build.
>>
>> Where this flag is used?
>> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
>> of 'compiler_glo
> From the error log we can see the root cause is that, develop_pd flag
> 'pd_CICompileOSR' is undeclared in zero build.
>
> Where this flag is used?
> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
> of 'compiler_globals.hpp' and further line 86 of 'globals_shared.hpp'.
>
