Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-08 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 19:30:17 GMT, Sergey Bylokhov wrote: >> It seems to be fine not to use UNIX epoch at first glance as long as we can >> know the timing of events, but I'm not sure (Thus I rewrote to comply with >> the original code). So I want to hear from the others. > > Did you check via

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-08 Thread Sergey Bylokhov
On Mon, 8 Mar 2021 07:46:54 GMT, Yasumasa Suenaga wrote: >> src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 80: >> >>> 78: uli.LowPart = ft.dwLowDateTime; >>> 79: uli.HighPart = ft.dwHighDateTime; >>> 80: return (uli.QuadPart / 1ULL) - 1164447360ULL;

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 06:37:07 GMT, Thomas Stuefe wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 35: > >> 33: #include >>

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 06:34:26 GMT, Thomas Stuefe wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 80: > >> 78:

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Thomas Stuefe
On Mon, 8 Mar 2021 00:56:24 GMT, Yasumasa Suenaga wrote: >> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): >> >> AccessBridgeDebug.cpp >> メモ: インクルード ファイル: >> d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h >> >> : >> >>

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Thomas Stuefe
On Sun, 7 Mar 2021 22:00:41 GMT, Sergey Bylokhov wrote: > > I wondered why C++ std headers are even used. The source code looks C-ish; > > but "8196681: Java Access Bridge logging and debug flags dynamically > > controlled" added some coding, adding a bunch of C++11x semantics and > >

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Yasumasa Suenaga
On Sun, 7 Mar 2021 22:00:41 GMT, Sergey Bylokhov wrote: >> Yes, including c++ standard library headers like means you need to >> deal with C++ exceptions thrown from library functions, and the code needs >> to be compiled with unwind capabilities. If its not switched on, and a C++ >>

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): > > AccessBridgeDebug.cpp > メモ: インクルード ファイル: > d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h > > : > >

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Sergey Bylokhov
On Sun, 7 Mar 2021 19:34:36 GMT, Thomas Stuefe wrote: > I wondered why C++ std headers are even used. The source code looks C-ish; > but "8196681: Java Access Bridge logging and debug flags dynamically > controlled" added some coding, adding a bunch of C++11x semantics and > included C++ std

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Thomas Stuefe
On Sun, 7 Mar 2021 16:19:15 GMT, Phil Race wrote: >> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): >> >> AccessBridgeDebug.cpp >> メモ: インクルード ファイル: >> d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h >> >> : >> >>

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Phil Race
On Sun, 7 Mar 2021 03:18:53 GMT, Yasumasa Suenaga wrote: > I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): > > AccessBridgeDebug.cpp > メモ: インクルード ファイル: > d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h > > : > >

RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-06 Thread Yasumasa Suenaga
I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): AccessBridgeDebug.cpp メモ: インクルード ファイル: d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h : c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\ostream(611): error C2220: