On Wed, 7 Apr 2021 21:59:15 GMT, Christoph Langer wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment per request from erikj79
>
> Cool, Lutz, you found it
Thank you for the review, Christoph!
I'll
On Wed, 7 Apr 2021 18:48:01 GMT, Lutz Schmidt wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> Lutz Schmidt has updated the
On Wed, 7 Apr 2021 19:06:26 GMT, Daniel D. Daugherty wrote:
>> Thumbs up.
>
> Side bar: I don't quite understand the commit history part of this PR.
> It looks like this PR was used for something else before it was used
> for this fix.
@dcubed-ojdk Please just ignore the commit history. For
On Wed, 7 Apr 2021 19:03:14 GMT, Daniel D. Daugherty wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment per request from erikj79
>
> Thumbs up.
Side bar: I don't quite understand the commit history
On Wed, 7 Apr 2021 18:48:01 GMT, Lutz Schmidt wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> Lutz Schmidt has updated the
On Wed, 7 Apr 2021 18:48:01 GMT, Lutz Schmidt wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> Lutz Schmidt has updated the
> May I please request reviews for this small build fix. It removes a linker
> warning by adding a assembly-time parameter which was previously missing. The
> same parameter is used at c++ compile time.
Lutz Schmidt has updated the pull request incrementally with one additional
commit since
