Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

2021-07-07 Thread Denghui Dong
On Wed, 7 Jul 2021 14:28:27 GMT, Erik Gahlin wrote: > The large check should only happen once `if (written > 127) {` in EventWriterHost::end_event_write could also be eliminated. - PR: https://git.openjdk.java.net/jdk/pull/4670

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

2021-07-07 Thread Erik Gahlin
On Sun, 4 Jul 2021 08:32:03 GMT, Denghui Dong wrote: > ``` > BenchmarkMode SamplesScore Score error Units > o.s.MyBenchmark.testEmitthrpt 20 8251457.275 2707.578 ops/s > ``` > > without this patch: That sounds too much. Could you please show the te

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

2021-07-04 Thread Denghui Dong
On Sat, 3 Jul 2021 00:46:13 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this improvement that eliminates 'is_large' check >> if the event size range is certain? >> >> JDK-8246260 introduced event large checks to reduce the recording size. >> This check could be eliminated at

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

2021-07-03 Thread Erik Gahlin
On Sat, 3 Jul 2021 00:46:13 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this improvement that eliminates 'is_large' check >> if the event size range is certain? >> >> JDK-8246260 introduced event large checks to reduce the recording size. >> This check could be eliminated at

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

2021-07-02 Thread Denghui Dong
> Hi, > > Could I have a review of this improvement that eliminates 'is_large' check if > the event size range is certain? > > JDK-8246260 introduced event large checks to reduce the recording size. > This check could be eliminated at compile/build time when one of the > following conditions is