Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Aleksey Shipilev
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Magnus Ihse Bursie
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Aleksey Shipilev
On Thu, 4 Nov 2021 13:17:13 GMT, Magnus Ihse Bursie wrote: > Shoot! ...as in "Approved"? :) - PR: https://git.openjdk.java.net/jdk/pull/6231

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Magnus Ihse Bursie
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Aleksey Shipilev
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Andrew John Hughes
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Andrew Haley
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Andrew Dinn
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > JDK-8182285 added the incremental build capabilities for modules, by hashing > the APIs of each module. > > The original change uses MD5, which is quite weak, and JDK-8214483 allows > `MessageDigest` to have no MD5 implementation.

RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Aleksey Shipilev
JDK-8182285 added the incremental build capabilities for modules, by hashing the APIs of each module. The original change uses MD5, which is quite weak, and JDK-8214483 allows `MessageDigest` to have no MD5 implementation. This is the cause of some build failures when using a FIPS-compliant