Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-26 Thread Daniel D . Daugherty
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-26 Thread Yumin Qi
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-26 Thread Alan Bateman
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-25 Thread Thomas Stuefe
On Tue, 25 Jan 2022 17:22:54 GMT, Yumin Qi wrote: >> I'm curious, under what circumstances would, before >> https://bugs.openjdk.java.net/browse/JDK-8237750, we ever hit the >> LoadLibrary in imageDecompressor.cpp? Did this ever work? Was there ever a >> scenario where the JVM was not

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-25 Thread Yumin Qi
On Tue, 25 Jan 2022 10:29:48 GMT, Thomas Stuefe wrote: > I'm curious, under what circumstances would, before > https://bugs.openjdk.java.net/browse/JDK-8237750, we ever hit the LoadLibrary > in imageDecompressor.cpp? Did this ever work? Was there ever a scenario where > the JVM was not

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-25 Thread Thomas Stuefe
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-24 Thread David Holmes
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-24 Thread Yumin Qi
On Tue, 25 Jan 2022 01:59:56 GMT, David Holmes wrote: > * The jimage code was using the OS code (dlopen/loadlibrary etc) to try and > load the zip library when needed. Yes. The zip library has to be in PATH. > * The VM, which is always loaded first, always used to load the zip library >

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-24 Thread David Holmes
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-24 Thread David Holmes
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-24 Thread Yumin Qi
Please review, When jlink with --compress=2, zip is used to compress the files while doing copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. This failure is after we get NULL from GetModuleHandle("zip.dll"), then do LoadLibrary("zip.dll") will have same result.