Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-13 Thread Andrew Leonard
On Tue, 12 Apr 2022 10:27:30 GMT, Magnus Ihse Bursie wrote: > Actually, a better option might be to let GCC append the `.file` > automatically to all assembly files. I think this can be done by creating a > file like `make/data/autoheaders/assemblyprefix.h` with: > > ``` > // ASSEMBLY_SRC_FILE

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-12 Thread Magnus Ihse Bursie
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote: >> This PR removes the need for relative object file linking introduced by >> JDK-8284437 for linux libraries, by specifying >> .file directives in the linux .S source files. The >> source files specify a .file ASSEMBLY_SRC_FILE >> where

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-12 Thread Magnus Ihse Bursie
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote: >> This PR removes the need for relative object file linking introduced by >> JDK-8284437 for linux libraries, by specifying >> .file directives in the linux .S source files. The >> source files specify a .file ASSEMBLY_SRC_FILE >> where

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread David Holmes
On Mon, 11 Apr 2022 21:03:22 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8284661: Reproducible assembly builds without relative linking >> >> Signed-off-by: Andrew Leonard > > Lo

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Andrew Leonard
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote: >> This PR removes the need for relative object file linking introduced by >> JDK-8284437 for linux libraries, by specifying >> .file directives in the linux .S source files. The >> source files specify a .file ASSEMBLY_SRC_FILE >> where

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Andrew Leonard
On Mon, 11 Apr 2022 21:03:22 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8284661: Reproducible assembly builds without relative linking >> >> Signed-off-by: Andrew Leonard > > Lo

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Magnus Ihse Bursie
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote: >> This PR removes the need for relative object file linking introduced by >> JDK-8284437 for linux libraries, by specifying >> .file directives in the linux .S source files. The >> source files specify a .file ASSEMBLY_SRC_FILE >> where

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Andrew Leonard
On Mon, 11 Apr 2022 17:40:58 GMT, Erik Joelsson wrote: >> @erikj79 As far as I can see only AIX is the exception of not being Linux >> and using .debuginfo suffix, are there others? >> I am currently testing AIX, so I will see if it passes, as you say, I would >> have my doubts it will! > > Sol

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Erik Joelsson
On Mon, 11 Apr 2022 17:26:12 GMT, Andrew Leonard wrote: >> test/jdk/build/AbsPathsInImage.java line 167: >> >>> 165: if (Files.isSymbolicLink(file)) { >>> 166: return super.visitFile(file, attrs); >>> 167: } else if (fileName.endsWith(".pdb"))

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Andrew Leonard
On Mon, 11 Apr 2022 16:53:41 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8284661: Reproducible assembly builds without relative linking >> >> Signed-off-by: Andrew Leonard > > test/jd

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Thomas Stuefe
On Mon, 11 Apr 2022 16:17:08 GMT, Andrew Leonard wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8284661: Reproducible assembly builds without relative linking >> >> Signed-off-by: Andrew Leonard > > @magic

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Erik Joelsson
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote: >> This PR removes the need for relative object file linking introduced by >> JDK-8284437 for linux libraries, by specifying >> .file directives in the linux .S source files. The >> source files specify a .file ASSEMBLY_SRC_FILE >> where

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Andrew Leonard
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote: >> This PR removes the need for relative object file linking introduced by >> JDK-8284437 for linux libraries, by specifying >> .file directives in the linux .S source files. The >> source files specify a .file ASSEMBLY_SRC_FILE >> where

Re: RFR: 8284661: Reproducible assembly builds without relative linking [v3]

2022-04-11 Thread Andrew Leonard
> This PR removes the need for relative object file linking introduced by > JDK-8284437 for linux libraries, by specifying > .file directives in the linux .S source files. The > source files specify a .file ASSEMBLY_SRC_FILE > where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk. > >