No further comments from me Erik!
Looks good.
Thanks,
David
On 5/07/2016 4:44 PM, Erik Joelsson wrote:
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8003593/webrev.02/
Only change is the name of the suppress variable.
On 2016-07-04 03:02, David Holmes wrote:
Fix typo ...
On 4/07/20
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8003593/webrev.02/
Only change is the name of the suppress variable.
On 2016-07-04 03:02, David Holmes wrote:
Fix typo ...
On 4/07/2016 9:01 AM, David Holmes wrote:
Hi Erik,
Only nit with that is the "source" tend to imply source code and
On 4/07/2016 10:21 AM, Phil Race wrote:
-Phil.
On Jul 3, 2016, at 4:55 PM, Phil Race wrote:
It is it all "extensions".
That should have read :
It is "not" all ...
True but they are all customizations - so SUPPRESS_CUSTOMIZATIONS
instead of SUPPRESS_CUSTOM_SOURCES ?
David
- Phil
I
Fix typo ...
On 4/07/2016 9:01 AM, David Holmes wrote:
Hi Erik,
On 2/07/2016 3:47 AM, Erik Joelsson wrote:
The separation between OpenJDK and Oracle's closed additions have
historically been quite messy. The build-infra project has tried to
improve on this, but failed in one regard, which was
-Phil.
> On Jul 3, 2016, at 4:55 PM, Phil Race wrote:
>
> It is it all "extensions".
That should have read :
It is "not" all ...
- Phil
> It is mostly just different internal code as far as we (se client) are
> concerned so the word extension has entirely the wrong connotation for people
It is it all "extensions". It is mostly just different internal code as far as
we (se client) are concerned so the word extension has entirely the wrong
connotation for people in SE api land.
-Phil.
> On Jul 3, 2016, at 4:01 PM, David Holmes wrote:
>
> Hi Erik,
>
>> On 2/07/2016 3:47 AM, Eri
Hi Erik,
On 2/07/2016 3:47 AM, Erik Joelsson wrote:
The separation between OpenJDK and Oracle's closed additions have
historically been quite messy. The build-infra project has tried to
improve on this, but failed in one regard, which was to hard code all
references to "closed" source instead of
On 2/07/2016 4:16 AM, Erik Joelsson wrote:
On 2016-07-01 19:59, Phil Race wrote:
erik,
SUPPRESS_CUSTOM_SOURCE"
FWIW "CLOSED" implies better to me what this is about than "CUSTOM".
Can't this be SUPPRESS_CLOSED_SOURCE ?
"custom" is a term that we have been using for a while now instead of
"c
On 2016-07-01 19:59, Phil Race wrote:
erik,
SUPPRESS_CUSTOM_SOURCE"
FWIW "CLOSED" implies better to me what this is about than "CUSTOM".
Can't this be SUPPRESS_CLOSED_SOURCE ?
"custom" is a term that we have been using for a while now instead of
"closed" in the open parts of the build to ref
erik,
SUPPRESS_CUSTOM_SOURCE"
FWIW "CLOSED" implies better to me what this is about than "CUSTOM".
Can't this be SUPPRESS_CLOSED_SOURCE ?
http://cr.openjdk.java.net/~erikj/8003593/webrev.01/jdk/make/mapfiles/libfontmanager/mapfile-vers.sdiff.html
Regarding all the freetype symbols in here .. th
The separation between OpenJDK and Oracle's closed additions have
historically been quite messy. The build-infra project has tried to
improve on this, but failed in one regard, which was to hard code all
references to "closed" source instead of using a variable. I decided to
finally fix this. A
11 matches
Mail list logo
